not folding constants for TCF_COMPILING cases

VERIFIED FIXED in mozilla0.9

Status

()

Core
JavaScript Engine
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: shaver, Assigned: shaver)

Tracking

({js1.5})

Trunk
mozilla0.9
js1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We don't fold constants in the TCF_COMPILING case, because of what looks like a
typo in
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/js/src&command=DIFF&root=/cvsroot&file=jsparse.c&rev1=3.48&rev2=3.49#29

We probably want to fold constants on pn2, rather than pn.  As sr= for that
checkin, I feel shame.  I'll attach the obvious patch for consideration.
Created attachment 25565 [details] [diff] [review]
proposed fix: fold constants on pn2
Status: NEW → ASSIGNED
Keywords: js1.5, patch, review
Target Milestone: --- → mozilla0.9
Thanks for catching this, late better than never!  sr=brendan@mozilla.org. 
Jband, how about a quick r=?

/be

Comment 3

17 years ago
r=jband
In the tree -- thanks, guys.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 5

17 years ago
Marking Verified - 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.