693099 - "Save Snapshot As" option on HTML5 videos creates PNG files with .JPG file extension

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 0. Be running Ubuntu Linux (I'm on 11.10 beta)

 1. Visit http://www.webmfiles.org/wp-content/uploads/video/big-buck-bunny_trailer.webm

 2. Right-click video, choose "Save Snapshot As"

 3. Try to open the resulting image in the default viewer, Gnome Image Viewer.

ACTUAL RESULTS:
It fails to open the image, giving this error message:
> Could not load image 'big-buck-bunny_trailer.jpg'.
> Error interpreting JPEG image file (Not a JPEG file: starts with 0x89 0x50)

So it appears the image might be corrupted in some way.  Other apps (Firefox, Gimp) seem to open the image just fine -- I'm not sure if this is from their image libraries being extra tolerant of minor image issues, or if the image is fine and Gnome Image Viewer is just buggy.

Filing this bug on whatever we might be able to do on the Gecko/Firefox side (encoding the JPG differently or something) to make this work.

VERSION INFORMATION:
Firefox Nightly user-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20111008 Firefox/10.0a1

Gnome Image Viewer (aka "eog" or "Eye of Gnome") package version:
3.2.0-0ubuntu1


(This might be better in Core | Video/Audio or Core | Imagelib.  Initially filing in Video Controls since this is a new available option, and I'm not sure what bits of Gecko code it uses into under the hood.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: example JPG snapshot created by Firefox that won't load in eog

Here's an example JPG that triggers this, if saved & loaded in eog

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of the error message in eog

Comment 3

[j.j.]

IrfanView says it's a PNG with wrong extension. Works if renamed. 
(BTW, filesize is far too big IMHO)

Comment 4

[j.j.]

Attachment: example JPG renamed as PNG

Comment 5

[j.j.]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> Created attachment 565758 [details]
> example JPG snapshot created by Firefox that won't load in eog

hah, even bugzilla calls it "image/png"

Comment 6

[Loic]

In fact I saw this error too. I asked the question why the snapshot gets PNG MIME type but shows JPG extension.
Cf https://bugzilla.mozilla.org/show_bug.cgi?id=681550#c14

Some image viewers  or image hosters may meet various issues to display/host such an image or a thumbnail of the image.

Comment 7

[Loic]

Maybe it would be useful to add an entry in about:config to choose between JPG/PNG (or more image formats), because saving PNG snapshots from 1080p HD videos (with rich contents like many colours/items e.g.) may imply a significant load/lag on the UI.

I tested with this 1080p video http://mirrorblender.top-ix.org/peach/bigbuckbunny_movies/big_buck_bunny_1080p_stereo.ogg and some snapshots reached 5.8 MB.

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Loic from comment #7)
> Maybe it would be useful to add an entry in about:config to choose between
> JPG/PNG

Perhaps supporting more than one output format would be useful -- but that should be tracked in a separate bug. Let's keep this bug on-topic.

Comment 9

[Justin Dolske [:Dolske]]

Hmm. The code is doing:

  canvas.toDataURL("image/jpg", "")

Maybe it's actually "image/jpeg"? Or maybe canvas is just broken?

We will at least need a spinoff bug to have canvas throw when an incorrect mimetype is specified.

Comment 10

[Justin Dolske [:Dolske]]

Attachment: Trivial patch

Yeah, this is just a glitch with the specified mimetype. Tested a quick patch and got a real JPEG (and resulting file size dropped from ~160K to 22K for one testcase).

Comment 11

[Justin Dolske [:Dolske]]

Trivial fix, so I went ahead and landed it. Will file followup for having <canvas> make more noise about this.

http://hg.mozilla.org/mozilla-central/rev/ccea01542d0b

Comment 12

[Justin Dolske [:Dolske]]

Filed bug 693539.

Comment 13

[[:Aleksej]]

VERIFIED FIXED (JPEG from WebM) with Aurora Mozilla/5.0 (X11; Linux x86_64; rv:12.0a2) Gecko/20120302 Firefox/12.0a2

Comment 14

[Mihaela Velimiroviciu (:mihaelav)]

Marking VERIFIED based on comment #13