693127 - "Inspect element" context menu shortcut is "Q"

Status: RESOLVED INVALID

(DevTools :: Inspector, defect)

Description

[Jesse Ruderman]

Right-clicking on a web page, I see "Inspect Element (Q)" on the context menu. This looks silly. The Q should be changed to something else so an existing letter can be underlined.

Comment 1

[Jo Hermans]

That's because of bug 587134 comment 35 :

> One side-effect was that the new context menu item access key is 'Q', since every letter in 'Inspect Element' was already used.

But that's not really true. N, T and L are still available. Or the name can be changed.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Jo Hermans from comment #1)
> That's because of bug 587134 comment 35 :
> 
> > One side-effect was that the new context menu item access key is 'Q', since every letter in 'Inspect Element' was already used.
> 
> But that's not really true. N, T and L are still available. Or the name can
> be changed.

That's what I thought too, until I came across the failed tests in:

browser/base/content/test/test_contextmenu.html 

If you can find a decent letter that doesn't fail this test, you'll be my hero.

Comment 3

[(no longer active)]

(In reply to Panos Astithas [:past] from comment #2)
> (In reply to Jo Hermans from comment #1)
> > That's because of bug 587134 comment 35 :
> > 
> > > One side-effect was that the new context menu item access key is 'Q', since every letter in 'Inspect Element' was already used.
> > 
> > But that's not really true. N, T and L are still available. Or the name can
> > be changed.
> 
> That's what I thought too, until I came across the failed tests in:
> 
> browser/base/content/test/test_contextmenu.html 
> 
> If you can find a decent letter that doesn't fail this test, you'll be my
> hero.

Why would changing the name or the access key have any effect on whether that test fails or passes?  That test checks for the ID of the menu items, and should be totally oblivious to their title and access key.

This looks really bad.  When I noticed it on Windows, I thought that I have a bad add-on which doesn't know how access keys work or something...

Note that even using an already used access key is better than "Q", since our code knows how to handle repeated access keys in a context (although that's clearly not ideal).

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> (In reply to Panos Astithas [:past] from comment #2)
> > (In reply to Jo Hermans from comment #1)
> > > That's because of bug 587134 comment 35 :
> > > 
> > > > One side-effect was that the new context menu item access key is 'Q', since every letter in 'Inspect Element' was already used.
> > > 
> > > But that's not really true. N, T and L are still available. Or the name can
> > > be changed.
> > 
> > That's what I thought too, until I came across the failed tests in:
> > 
> > browser/base/content/test/test_contextmenu.html 
> > 
> > If you can find a decent letter that doesn't fail this test, you'll be my
> > hero.
> 
> Why would changing the name or the access key have any effect on whether
> that test fails or passes?  That test checks for the ID of the menu items,
> and should be totally oblivious to their title and access key.

See bug 587134 comment 32 for many of the failed tests. For a sneak preview:

failed | menuitem context-inspect has same accesskey as context-sendimage

Comment 5

[Tomer Cohen :tomer]

This bug is still unresolved on Aurora 13. We have released Firefox 11 with this issue, and I am seeing people that mention the invalid accesskey as part of context menu item (Google for "Inspect Element (Q)").

http://mxr.mozilla.org/mozilla-aurora/source/browser/locales/en-US/chrome/browser/browser.dtd#199

Comment 6

[Brian Di Palma]

Is an access key required? Chrome doesn't seem have any and they have the Inspect element entry in their menu.

Comment 7

[Paul Rouget [:paul]]

triage. Filter on PINKISBEAUTIFUL

Comment 8

[Kevin Dangoor]

I just did a Google search for the past month and found that people are still talking about Inspect Element (Q)... In fact, here's a blog post calling the feature the Q element inspector:

http://www.luketarplin.com/blog/firefox-q-inspector

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

There isn't an access key anymore, so I'm marking this as invalid

Comment 10

[Robert Kaiser]

(In reply to Nicolas Chevobbe from comment #9)
> There isn't an access key anymore, so I'm marking this as invalid

No access key on a menu element is an accessibility bug by itself.

Comment 11

[Paul Rouget [:paul]]

Steps:
- Right click on an element
- Press Q
- Devtools show up

So it's still here.

Many people, me included, use these steps to open the inspector.

So let's keep it that way.

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Paul Rouget [:paul] from comment #11)
> Steps:
> - Right click on an element
> - Press Q
> - Devtools show up
> 
> So it's still here.
> 
> Many people, me included, use these steps to open the inspector.
> 
> So let's keep it that way.

Weird, it doesn't for me ( maybe because of my keyboard layout, or maybe the OS ? )
Anyway, we keep this bug resolved then ?