69313 - Savings fom extra data/computations related to GetBoundingMetrics

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[rbs]

The nsBoundingMetrics struct, defined in nsIRenderingContext.h, includes
the following members: 

  nscoord supItalicCorrection, subItalicCorrection, leftItalicCorrection;

They were not computed correctly (see below), and the XP code in layout/mathml
is not making any use of them. Instead, some simple estimations are proving 
quite satsifactory at the XP level. As a result, these members have become
useless and can be removed for performance and footprint reasons.

            // get italic correction
This is returning the angle, not the final value. Even that angle is
incorrect on X-based systems.
2066        XFontStruct *fontInfo = (XFontStruct *) GDK_FONT_XFONT (mFont);
2067        unsigned long pr = 0;
2068        if (::XGetFontProperty(fontInfo, XA_ITALIC_ANGLE, &pr)) {
2069           aBoundingMetrics.subItalicCorrection = (gint) pr; 
2070           aBoundingMetrics.supItalicCorrection = (gint) pr;
2071        }

gfx/src/xprint/nsFontMetricsXP.{h,cpp}
gfx/src/xprint/nsFontMetricsGTK.{h,cpp}

GetItalicSlope() is also not necessary anymore
gfx/src/xprint/nsFontMetricsWin.{h,cpp}

Comment 1

[rbs]

Attachment: Proposed patch for the cleanup

Comment 2

[rbs]

Guys, want to give me a quick r/sr on this - should be a no-brainer.

Comment 3

[rbs]

Attachment: patch which includes xprint too

Comment 4

[Erik van der Poel]

sr=erik for 2nd patch

Comment 5

[kill this account]

r=[e-mail]

Comment 6

[rbs]

Thanks guys. Checked-in.
Resolving as FIXED.