693217 - Can't download my addon

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

Description

[Erik Vold]

When I try to download https://builder.addons.mozilla.org/addon/1019777/latest/ I get a spinner for a few minutes then the spinner stops and nothing happens.

When I try to download https://builder.addons.mozilla.org/addon/1004755/latest/ it works perfectly.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Same thing here.
After I click "Download", the web console's net tab shows a bunch of calls like
[19:22:22.623] GET https://builder.addons.mozilla.org/xpi/check_download/1019777r4/ [HTTP/1.1 200 OK 104ms]


Clicking the "Test" button, builder pops up a huge red error box, and the web console logged
[19:23:11.003] GET https://builder.addons.mozilla.org/xpi/test/1019777r4/ [HTTP/1.1 404 NOT FOUND 106ms]

Comment 2

[Piotr Zalewa [:zalun]]

First file contains a "var {UserScript} ="
I haven't seen this construct before ... Are you sure it's a valid JS?

Comment 3

[Sean McArthur [:seanmonstar]]

@zalun: It is (Firefox only). It's used through the SDK, even.

Comment 4

[Erik Vold]

(In reply to Piotr Zalewa [:zalun] from comment #2)
> First file contains a "var {UserScript} ="
> I haven't seen this construct before ... Are you sure it's a valid JS?

Yeah, it's called a destructuring assignment. 

https://developer.mozilla.org/en/New_in_JavaScript_1.7#Destructuring_assignment_(Merge_into_own_page.2Fsection)

Comment 5

[Daniel Buchner [:dbuc]]

Hey Erik,

I think it is a module scoping issue. I modified your Userscripts library via a copy of your add-on (https://builder.addons.mozilla.org/addon/1019947/latest/) and now it both test installs and downloads fine.

When I first tried your add-on via test, there was an error thrown out of the greasemonkey-api.js file indicating that a module was not found when it was being constructed. What was happened is that when you required the tabs and clipboard APIs in the greasemonkey-api.js file, the string used was simply "tabs" and "clipboard", I changed this to "addon-kit/tabs" and "addon-kit/clipboard" and the error was corrected.

I will look into the path stuff and see if we can't do the same thing with addon-kit scoping that we do with api-utils.

Comment 6

[Piotr Zalewa [:zalun]]

Is this still an issue under new SDK?

Comment 7

[Sean McArthur [:seanmonstar]]

Reopen if it's still an issue.