693302 - Duplicated output on fennec for windows

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

Attachment: Do not use logfile trick with fennec on windows

I don't know why, but we don't need the stdout file trick on Fennec/Win32!
So that we currently get duplicated stdout: regular one + file.

Comment 1

[Brian Warner [:warner :bwarner]]

Comment on attachment 565937 [details] [diff] [review]
Do not use logfile trick with fennec on windows

looks good. The only style thing I'd suggest is to enclose the 'if' condition in parentheses instead of using the backslash. So:

  if (sys.platform in ['win32', 'cygwin']
      and not (enable_mobile or app_type in ['fennec'])):
      ....

(I also tend to put the 'and' at the beginning of the second line, instead of at the start of the first, as a reminder to the reader that there's an earlier statement they should pay attention to).

but either way, looks good!

Comment 2

[Brian Warner [:warner :bwarner]]

Take a look at Bug 692554, where Myk is removing the conditional and using the logfile trick all the time, which will conflict with this. I suspect that the "redirect runner output to /dev/null" change in that patch may fix your problem here, so I'd suggest applying his patch and see if that removes the need for this one, before landing this.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This landed as part of https://github.com/mozilla/addon-sdk/commit/1caff283e90eacff1ab34ae4eda8f6dfb4901325