693360 - Auto-filling appver/platform on search sucks

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jeff Balogh (:jbalogh)]

1. No indication of the filter in the sidebar.
2. Filtering by 10.0a1 limits the number of results from 255 to 28.
3. Every time I remove the appver and do another search the filter comes back.

https://addons.mozilla.org/en-US/firefox/search/es?q=firebug&cat=all&appver=10.0a1&platform=mac

http://cl.ly/1r2i2d400v1R3S3p2w3x

Comment 1

[Jeff Balogh (:jbalogh)]

The feature came from bug 688344.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

phew, it's gone
https://github.com/jbalogh/zamboni/commit/2b1af37

Comment 3

[Justin Scott [:fligtar]]

(In reply to Jeff Balogh (:jbalogh) from comment #0)
> 1. No indication of the filter in the sidebar.

From the mock (http://fligtar.github.com/amo-redux/search.html) and implementation bug 684340:
"When a facet has been changed to a non-default value, it becomes orange. This makes it easier for users to notice that they're seeing a limited set. For example, when searching from a specific add-on type page, that category should be pre-selected and orange."

If this was implemented as expected, it would be much more obvious that the criteria had been applied. We plan to make this even clearer in bug 692540, and search suggestions will help for people searching for a specific add-on name as they aren't limited to only compatible add-ons.

> 2. Filtering by 10.0a1 limits the number of results from 255 to 28.

There are things to improve about the experience for pre-release testers, but my primary concern is for stable channel users. According to the compatibility dashboard only 54% of active add-ons are compatible with Firefox 7, the current stable version. Which means without this, half of the add-ons they see can't even be installed. We should hide those by default. Pre-release users are smart enough to figure out how to get what they want, assuming we provide them the appropriate clues and don't have bugs like:

> 3. Every time I remove the appver and do another search the filter comes
> back.
> 
> https://addons.mozilla.org/en-US/firefox/search/
> es?q=firebug&cat=all&appver=10.0a1&platform=mac
> 
> http://cl.ly/1r2i2d400v1R3S3p2w3x

I'm not sure of the exact STR here but we should make sure that if we're filtering by an appversion or any other facet that it shows up in the sidebar.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

if the user's appversion is 10.0a2, we filter results with minVer=10.0. and if there's an appversion for 10.0, "Firefox 10.0" will show up (in orange) on the sidebar filters.

https://github.com/jbalogh/zamboni/commit/8176d34