Since the send later button is really the send button with the label changed, its image can't be changed. Proposed patch fixes this by using a deck of two buttons.
Keywords: patch, review, ui
OS: Windows 95 → All
Hardware: PC → All
If I correctly understand your patch, you are proposing to have two button instead of one in the toolbar, right? Can you attach a screen dump of the toolbar. Thanks cc'ing jglick for UI change approval
Status: NEW → ASSIGNED
Is this adding another button to the Toolbar or just adding the ability to change the current button (text and/or image) to "Send Later" when it is the default action (user is offline)?
This is adding the ability to change the image. The text used to change anyway. The deck simply selects between the two buttons, they don't appear simultaneously.
oh great. Let me try this patch...
I've noticed an additional advantage. The Send Later text doesn't fit in my buttons so that the other buttons were shifed out of the way. But with the deck method the Send button is stretched to the width of the Send Later button. There is a disadvantage - the deck creates an extra native window.
Instead of using the deck, why not just set some attribute on the button like mode="savenow" or "savelater". Then the CSS can swap the image based on that attribute.
Such as observing the Communicator:WorkMode? Adding dependency on 79801.
Depends on: 79801
The patch looks good. But can I see the new images?
They already exist. jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater.gif jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater-disabled.gif jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater-hover.gif jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater-hover-active.gif
my mistake, I was looking at the modern theme! About modern theme, do we plane to do the same? Anyway, Thanks for implementing this. R=ducarroz
change qa contact->nbaca
QA Contact: sheelar → nbaca
Fix checked in. Thanks Neil for the patch.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Thanks to everybody who helped me learn about contributing to Mozilla.
Thank you for contributing to Mozilla...
Branch Build 2001-07-02-03: WinMe, Mac 9.04 Branch Build 2001-07-02-06: Linux RH 6.2 Verified Fixed, looks great!
Status: RESOLVED → VERIFIED
[RFE] is deprecated in favor of severity: enhancement. They have the same meaning.
Severity: minor → enhancement
You need to log in before you can comment on or make changes to this bug.