[RFE] Should be able to skin image for send later button.

VERIFIED FIXED

Status

MailNews Core
Composition
--
enhancement
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Jean-Francois Ducarroz)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
Since the send later button is really the send button with the label changed,
its image can't be changed. Proposed patch fixes this by using a deck of two
buttons.
(Reporter)

Comment 1

17 years ago
Created attachment 25590 [details] [diff] [review]
Proposed patch
Keywords: patch, review, ui
OS: Windows 95 → All
Hardware: PC → All

Updated

17 years ago
QA Contact: esther → sheelar
(Assignee)

Comment 2

17 years ago
If I correctly understand your patch, you are proposing to have two button
instead of one in the toolbar, right? Can you attach a screen dump of the
toolbar. Thanks

cc'ing jglick for UI change approval
Status: NEW → ASSIGNED

Comment 3

17 years ago
Is this adding another button to the Toolbar or just adding the ability to 
change the current button (text and/or image) to "Send Later" when it is the 
default action (user is offline)?
(Reporter)

Comment 4

17 years ago
This is adding the ability to change the image. The text used to change anyway.
The deck simply selects between the two buttons, they don't appear simultaneously.
(Assignee)

Comment 5

17 years ago
oh great. Let me try this patch...
(Reporter)

Comment 6

17 years ago
I've noticed an additional advantage. The Send Later text doesn't fit in my
buttons so that the other buttons were shifed out of the way. But with the deck
method the Send button is stretched to the width of the Send Later button.

There is a disadvantage - the deck creates an extra native window.

Comment 7

17 years ago
Instead of using the deck, why not just set some attribute on the button like
mode="savenow" or "savelater".  Then the CSS can swap the image based on that
attribute.
(Reporter)

Comment 8

17 years ago
Such as observing the Communicator:WorkMode? Adding dependency on 79801.
Depends on: 79801
(Reporter)

Comment 9

17 years ago
Created attachment 37908 [details] [diff] [review]
Revised patch as per Hewitt's comment

Comment 10

17 years ago
sr=hewitt
(Assignee)

Comment 11

17 years ago
The patch looks good. But can I see the new images?
(Reporter)

Comment 12

17 years ago
They already exist.
jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater.gif
jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater-disabled.gif
jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater-hover.gif
jar:resource://chrome/classic.jar!/skin/classic/messenger/messengercompose/sendlater-hover-active.gif
(Assignee)

Comment 13

17 years ago
my mistake, I was looking at the modern theme! About modern theme, do we plane
to do the same?

Anyway, Thanks for implementing this. R=ducarroz

Comment 14

17 years ago
change qa contact->nbaca
QA Contact: sheelar → nbaca

Comment 15

17 years ago
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989
(Assignee)

Comment 16

17 years ago
Fix checked in. Thanks Neil for the patch.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 17

17 years ago
Thanks to everybody who helped me learn about contributing to Mozilla.
(Assignee)

Comment 18

17 years ago
Thank you for contributing to Mozilla...

Comment 19

17 years ago
Branch Build 2001-07-02-03: WinMe, Mac 9.04
Branch Build 2001-07-02-06: Linux RH 6.2
Verified Fixed, looks great!
Status: RESOLVED → VERIFIED

Comment 20

15 years ago
[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.
Severity: minor → enhancement
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.