693389 - Update urlclassifier DB for Mozilla com->org move

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

After the move of all mozilla content from mozilla.com to mozilla.org, users going directly to mozilla.com/firefox/its-a-trap.html will get the correct warning because that URL is in the DB.

However, people who go to directly to mozilla.org/firefox/its-a-trap.html will not get a warning. This could cause confusion if they discover those pages for example due to a Google search.

Update the Urlclassifier DB to the new URL.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Update urlclassifier DB to .org domains

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Currently both of our Mozmill tests which check those pages are broken. We need an update of the database to get those fixed. Can we get some progress on the requested review please? Thanks.

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 566212 [details] [diff] [review]
Patch 1. Update urlclassifier DB to .org domains

Review of attachment 566212 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but did you verify that no other tests are using mozilla.com in server-locations.txt?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

>r+, but did you verify that no other tests are using mozilla.com in server-
>locations.txt?

There's this:

# This is here so that we don't load the default live bookmark over
# the network in every test suite.
http://fxfeeds.mozilla.com:80

Make a separate bug for it? Unlike SB tests, it prolly just uses the redirect without issues.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff13fc7b5e42

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ff13fc7b5e42

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a1) Gecko/20111112 Firefox/11.0a1 and a fresh profile.

Comment 8

[KLB]

This bug fix appears to be breaking

https://www.mozilla.org/firefox/its-a-trap.html
https://www.mozilla.org/firefox/its-an-attack.html

Which we regularly use as AMO editors to test addons, more specifically themes.  Testing against about:blocked and about:certerror is not sufficient because the behavior isn't 100% the same.

Do I need to file a new bug to get these URLs fixed?

Comment 9

[Gian-Carlo Pascutto [:gcp]]

>This bug fix appears to be breaking

Can you explain what you mean? I don't understand.

Comment 10

[KLB]

Maybe it isn't this bug exactly, but ever since this morning going to the two links I mentioned above does not result in the proper warnings.

Comment 11

[Gian-Carlo Pascutto [:gcp]]

Please file a separate bug.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As mentioned above it works with a fresh profile. I haven't actually tested which files of an existing profile have to be removed to get Firefox showing up those warning pages.

Comment 13

[KLB]

Gain-Carlo,

Per your instructions, bug 707652 was filed.

Comment 14

[Alex Keybl [:akeybl]]

Please nominate for consideration for FF9/10, noting any possible risks. com->org feels low risk to me though.

Comment 15

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 566212 [details] [diff] [review]
Patch 1. Update urlclassifier DB to .org domains

[Approval Request Comment]
Regression caused by (bug #): Reworking of the Mozilla.com/org websites
User impact if declined: Users might inadvertently think the phishing protection no longer works
Testing completed (on m-c, etc.): Baked for several weeks in Aurora
Risk to taking this patch (and alternatives if risky): None known

Comment 16

[Alex Keybl [:akeybl]]

Comment on attachment 566212 [details] [diff] [review]
Patch 1. Update urlclassifier DB to .org domains

[Triage Comment]
Simple .com -> .org switch for its-an-attack.html and its-a-trap.html. Approved for beta.

Comment 17

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ba868a26c6c