This only affects old-style ("xul") extensions (bug 641215). To reproduce you need to run cfx xpi with a non-default template that has default preferences ('addon.xpi!/defaults/preferences/*.js'). bug 686008 in https://github.com/mozilla/addon-sdk/commit/d98f1d0af8bdb97e3c8af2b7f1a80f027fc67126 changed the directory filter for template from [".svn", ".hg", ".git"] to [".git", ".svn", ".hg", "defaults"], the latter was only used for the data/ subtree before. I couldn't find any reason behind ignoring "defaults" inside the data/ directory either - blame points to a huge checkin for bug 627607 <https://github.com/mozilla/addon-sdk/commit/a020fa100b84415724c98803d4a8772752ef7fbf> and there's no reference to any discussion about that. Is there any reason "defaults" cannot be removed from the common filter list?
Brian, was there any reason for including "defaults"?
Created attachment 566956 [details] [diff] [review] stop removing 'defaults' when building an XPI
Comment on attachment 566956 [details] [diff] [review] stop removing 'defaults' when building an XPI Review of attachment 566956 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Brian, thanks for the quick fix!