693422 - Make possible for Qt FF create main QGraphicsView outside of XPCOM (ala faststart static UI feature)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

In order to fix bug 692479, we should create Qt widget structure before XPCOM created with statically painted fake UI, and when XUL started be able to replace toplevel widget with real nsIWidget.

In order to do that we should make MozQGraphicsView more universal and compilable outside of widget code (in faststartup component)

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Prepare Qt-nsWindow/Widget for fast startup static view

Comment 2

[Oleg Romashin (:romaxa)]

I just create IMozQWidget interface which can be used by Static UI widget, and made QGraphicsView based class less dependent on widget/qt internals

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Move QApp/Meego stuff into common place nsQAppInstance

Always wanted to do this, but now it seems needed. in order to create QApp outside of xpcom, and don't duplicate code

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Move QApp/Meego stuff into common place nsQAppInstance

Fixed some typos.

Comment 5

[Oleg Romashin (:romaxa)]

Comment on attachment 566114 [details] [diff] [review]
Move QApp/Meego stuff into common place nsQAppInstance

ok, this need some more work to do, because we cannot use XRE stuff outside of XPCOM...

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Prepare Qt-nsWindow/Widget for fast startup static view

Fixed dynamic cast compile problem on maemo5

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Move QApp/Meego stuff into common place nsQAppInstance

Comment 8

[Oleg Romashin (:romaxa)]

Comment on attachment 566354 [details] [diff] [review]
Prepare Qt-nsWindow/Widget for fast startup static view

Tatiana could you review this carefully?

Comment 9

[Oleg Romashin (:romaxa)]

Comment on attachment 566355 [details] [diff] [review]
Move QApp/Meego stuff into common place nsQAppInstance

and this one too

Comment 10

[Tatiana Meshkova (:tatiana)]

Comment on attachment 566354 [details] [diff] [review]
Prepare Qt-nsWindow/Widget for fast startup static view


> #ifdef MOZ_PLATFORM_MAEMO
>         if (GetShouldAccelerate()) {
>-            newView->setViewport(new QGLWidget());
>+            QGLWidget *glWidget = qobject_cast<QGLWidget*>(newView->viewport());
>+            if (!glWidget) {
>+                newView->setViewport(new QGLWidget());
>+            }

I guess this should go as separate patch and maybe bug.
Also explain why you are trying to reuse existing viewport now.

Comment 11

[Tatiana Meshkova (:tatiana)]

Comment on attachment 566355 [details] [diff] [review]
Move QApp/Meego stuff into common place nsQAppInstance


> #if (MOZ_PLATFORM_MAEMO == 6)
>-    QApplication::setStyle(QLatin1String("windows"));
>-    if (!gArgc) {
>-      gArgv[gArgc] = strdup("nsQAppInstance");
>-      gArgc++;
>+    // Should create simple windows style for non chrome process
>+    if (!aDefaultProcess) {
>+      QApplication::setStyle(QLatin1String("windows"));

motif? ;)
Please explain, why it's bad to run with platform default style.

>+    }
>+    if (!aArgc) {
>+      aArgv[aArgc] = strdup("nsQAppInstance");
>+      aArgc++;
>     }
> #endif
>-    sQAppInstance = new QApplication(gArgc, gArgv);
>+    sQAppInstance = new QApplication(aArgc, aArgv);
>+#ifdef MOZ_ENABLE_MEEGOTOUCH
>+    if (aDefaultProcess)
>+    {
>+      gArgv[gArgc] = strdup("-software");
>+      gArgc++;
>+      sMComponentData = new MComponentData(aArgc, aArgv, "", new MApplicationService(""));
>+    }
>+#endif

I guess, these style and -software should be separated together with viewport thing from first patch.
Also explain this -software flag from viewport trick perspective.
Using -software flag together with QGLWidget viewport might confuse.

Comment 12

[Oleg Romashin (:romaxa)]

Attachment: Prepare Qt-nsWindow/Widget for fast startup static view

Comment 13

[Oleg Romashin (:romaxa)]

Attachment: Move QApp/Meego stuff into common place nsQAppInstance

I guess motif style is not available everywhere...

Comment 14

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09c76e77d57c
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1561460dffb

Comment 15

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/b1561460dffb
https://hg.mozilla.org/mozilla-central/rev/09c76e77d57c