Last Comment Bug 693432 - IonMonkey: Apply TypeBarriers to Calls
: IonMonkey: Apply TypeBarriers to Calls
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
:
Mentors:
Depends on: 684402
Blocks: IM+TI
  Show dependency treegraph
 
Reported: 2011-10-10 14:11 PDT by David Anderson [:dvander]
Modified: 2011-10-12 14:51 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (12.02 KB, patch)
2011-10-10 16:56 PDT, David Anderson [:dvander]
bhackett1024: review+
Details | Diff | Splinter Review

Description David Anderson [:dvander] 2011-10-10 14:11:28 PDT
Calls need to push a type barrier to be correct with respect to TypeInference.
Comment 1 David Anderson [:dvander] 2011-10-10 16:56:41 PDT
Created attachment 566081 [details] [diff] [review]
patch

This patch cleans up the logic in applying type barriers, so they can be placed after calls. It also makes TypeBarriers work on non-idempotent instructions, calling TypeScript::Monitor on relevant bailouts.
Comment 2 David Anderson [:dvander] 2011-10-12 14:51:51 PDT
http://hg.mozilla.org/projects/ionmonkey/rev/6f67262319be

Note You need to log in before you can comment on or make changes to this bug.