Last Comment Bug 693519 - Don't call GetHitDepthAtPoint if we didn't hit anything
: Don't call GetHitDepthAtPoint if we didn't hit anything
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: Matt Woodrow (:mattwoodrow)
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks: 505115
  Show dependency treegraph
 
Reported: 2011-10-10 20:38 PDT by Matt Woodrow (:mattwoodrow)
Modified: 2011-10-12 03:22 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Don't call GetHitDepthAtPoint when we didn't hit anything (2.89 KB, patch)
2011-10-10 20:38 PDT, Matt Woodrow (:mattwoodrow)
roc: review+
Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2011-10-10 20:38:39 PDT
Created attachment 566115 [details] [diff] [review]
Don't call GetHitDepthAtPoint when we didn't hit anything

This is causing some harmless assertions with hidden backfaces/ singular matrices.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-10-11 05:18:17 PDT
Use !IsEmpty() rather than Length(), please?
Comment 2 Matt Woodrow (:mattwoodrow) 2011-10-11 20:18:02 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/854ad493859a

Sorry, missed the IsEmpty() comment. I can do a follow-up to fix this.
Comment 3 Marco Bonardo [::mak] 2011-10-12 03:21:21 PDT
https://hg.mozilla.org/mozilla-central/rev/854ad493859a

Note You need to log in before you can comment on or make changes to this bug.