Closed Bug 693577 Opened 8 years ago Closed 8 years ago

port mockprovider.js to specialpowers

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: jmaher, Assigned: jmaher)

Details

(Whiteboard: [specialpowers][inbound])

Attachments

(1 file)

mockprovider.js has a couple instances of enablePrivilege and we need to port this to work with special powers
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #566177 - Flags: review?(ted.mielczarek)
Comment on attachment 566177 [details] [diff] [review]
port mockprovider.js to special powers (1.0)

Review of attachment 566177 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/tests/SimpleTest/specialpowersAPI.js
@@ +688,5 @@
>                     withCaret ? ctx.DRAWWINDOW_DRAW_CARET : 0);
>      return el;
>    },
> +  
> +  cycleFactoryRegistration: function(cid, contractID, mockFactory, originalFactory) {  

Since you use this both to register the mock and re-register the original, maybe we should rename the parameters? How about "originalFactory" and "newFactory"? Or "old" and "new".

Also I think I'd like to call this function "swapFactoryRegistration" or something like that.
Attachment #566177 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7aa590bd507
Whiteboard: [specialpowers] → [specialpowers][inbound]
https://hg.mozilla.org/mozilla-central/rev/c7aa590bd507
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.