Bootstrapped addons have uninstall & install called on Firefox update

RESOLVED FIXED in mozilla10

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: zpao, Assigned: darktrojan)

Tracking

7 Branch
mozilla10
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

On first startup for Firefox 7 updating from Firefox 6, my addon's uninstall method is called immediately followed by it's install method. This is rather unfortunate and unexpected as my addon resets a pref on uninstall and sets a default value on install. This value can be customized by users so people are losing those custom values and blaming my addon (and creating custom versions with different defaults hardcoded & uploading those to third party sites so they'll never update).
Paul foolishly claimed he might want to take a look at this. Unassign if you change your mind.
Assignee: nobody → paul
Foolishly indeed. I'm not feeling well equipped to dig into this. The AOM code looks nice, but there's a lot of it and somebody more familiar with it should be better to jump in. I may look at this in the future if it's still open.
Assignee: paul → nobody
Hernan, not sure if you have other bugs to work on, but I thought this might be in the realm of things you could look at on a more limited schedule if you're interested.
Note to whomever works on this: Happens when DB schema changes.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 5

7 years ago
Created attachment 567956 [details] [diff] [review]
patch
Attachment #567956 - Flags: review?(bmcbride)
Attachment #567956 - Flags: review?(bmcbride) → review?(dtownsend)
Comment on attachment 567956 [details] [diff] [review]
patch

Review of attachment 567956 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent
Attachment #567956 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
The patch fails to apply.
Keywords: checkin-needed
(Assignee)

Comment 8

7 years ago
Created attachment 568915 [details] [diff] [review]
patch v2
Attachment #567956 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 568915 [details] [diff] [review]
patch v2

The unbitrotting here has slightly changes the effect of the patch. I'd switch the if statements there back to what they were before I simplified them
Keywords: checkin-needed
(Assignee)

Comment 10

7 years ago
Created attachment 568921 [details] [diff] [review]
patch v3
Attachment #568915 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
The patch still doesn't apply on mozilla-inbound.
Keywords: checkin-needed
(Assignee)

Comment 12

7 years ago
Created attachment 568941 [details] [diff] [review]
patch v4

(In reply to Dão Gottwald [:dao] from comment #11)
> The patch still doesn't apply on mozilla-inbound.

Mossop is determined to bitrot me!
Attachment #568921 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Has this been sent to try, or do I need to do so before pushing? Just slightly wary after the mozilla-beta landings/backouts in the other bug ;-)

Updated

7 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/82c53e5e8fcb
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.