693714 - Bootstrapped addons have uninstall & install called on Firefox update

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

On first startup for Firefox 7 updating from Firefox 6, my addon's uninstall method is called immediately followed by it's install method. This is rather unfortunate and unexpected as my addon resets a pref on uninstall and sets a default value on install. This value can be customized by users so people are losing those custom values and blaming my addon (and creating custom versions with different defaults hardcoded & uploading those to third party sites so they'll never update).

Comment 1

[Dave Townsend [:mossop]]

Paul foolishly claimed he might want to take a look at this. Unassign if you change your mind.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Foolishly indeed. I'm not feeling well equipped to dig into this. The AOM code looks nice, but there's a lot of it and somebody more familiar with it should be better to jump in. I may look at this in the future if it's still open.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Hernan, not sure if you have other bugs to work on, but I thought this might be in the realm of things you could look at on a more limited schedule if you're interested.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note to whomever works on this: Happens when DB schema changes.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: patch

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 567956 [details] [diff] [review]
patch

Review of attachment 567956 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent

Comment 7

[Dão Gottwald [:dao]]

The patch fails to apply.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: patch v2

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 568915 [details] [diff] [review]
patch v2

The unbitrotting here has slightly changes the effect of the patch. I'd switch the if statements there back to what they were before I simplified them

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: patch v3

Comment 11

[Dão Gottwald [:dao]]

The patch still doesn't apply on mozilla-inbound.

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: patch v4

(In reply to Dão Gottwald [:dao] from comment #11)
> The patch still doesn't apply on mozilla-inbound.

Mossop is determined to bitrot me!

Comment 13

[Ed Morley [:emorley]]

Has this been sent to try, or do I need to do so before pushing? Just slightly wary after the mozilla-beta landings/backouts in the other bug ;-)

Comment 14

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=a815c6e1c159

https://hg.mozilla.org/integration/mozilla-inbound/rev/82c53e5e8fcb

Comment 15

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/82c53e5e8fcb