693845 - CMOVD support for MIPS

Status: RESOLVED WONTFIX

(Core Graveyard :: Nanojit, defect)

Description

[Chris Dearman]

Attachment: Implement CMOVD for MIPS

Nanojit random tests fail when using CMOVD

This patch is dependent on https://bugzilla.mozilla.org/attachment.cgi?id=566358

With both patches applied all of the nanojit testcases (including random) pass and there are no new regressions on tamarin-redux

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 566381 [details] [diff] [review]
Implement CMOVD for MIPS

Review of attachment 566381 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but consider this a very "light" review since I don't know MIPS.

Comment 2

[Chris Dearman]

(In reply to Nicholas Nethercote [:njn] from comment #1)
> r=me, but consider this a very "light" review since I don't know MIPS.

Should I get someone else to take a look at this or are you ok to merge it as is?

Thanks

Comment 3

[Nicholas Nethercote [inactive]]

Oh, go for it.  I can't remember -- do you have commit access?

Comment 4

[Edwin Smith]

R+ too, and you can also use rreitmai or wmaddox for review+land requests; they're even in your timezone.

If the style of prepareResultReg and freeResourcesOf is patterned after ARM then it should be ok.

Comment 5

[Chris Dearman]

I don't have commit access. Will someone commit this?

Comment 6

[Edwin Smith]

to rreitmai 4 commit.

Comment 7

[Rick Reitmaier]

chris http://hg.mozilla.org/projects/nanojit-central/rev/af2112567164

Comment 8

[Tamarin Bot]

changeset: 6735:057d70ce3455
user:      Chris Dearman <chris>
summary:   Bug 693845 - CMOVD support for MIPS (r+nnethercote)

http://hg.mozilla.org/tamarin-redux/rev/057d70ce3455

Comment 9

[Nicholas Nethercote [inactive]]

Nanojit has been dead for several years. Its Bugzilla component has been moved to the graveyard (bug 984276).

I checked all the open bugs. They're all uninteresting, so I'm WONTFIXing them all. Apologies for the bugspam.