693959 - convert quit.js to specialpowers

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

quit.js uses enable privilege and we need this to use specialpowers.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: port quit.js to specialpowers (1.0)

patch cleans up a lot of stuff now that we don't need ipc.js/ipc-overlay.xul.

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 566489 [details] [diff] [review]
port quit.js to specialpowers (1.0)

\o/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 566489 [details] [diff] [review]
port quit.js to specialpowers (1.0)

Review of attachment 566489 [details] [diff] [review]:
-----------------------------------------------------------------

Lots of nice code removal. :)

::: testing/mochitest/specialpowers/components/SpecialPowersObserver.js
@@ +171,5 @@
>                    .messageManager
>                    .sendAsyncMessage("SPPingService", { op: "pong" });
>          }
>          break;
> +      case "Quitter.Quit":

You should probably rename this to SpecialPowers.Quit.

::: testing/mochitest/tests/SimpleTest/ChromePowers.js
@@ +104,5 @@
> +  // We come in here as SpecialPowers.quit, but SpecialPowers is really ChromePowers.
> +  // For some reason this.<func> resolves to TestRunner, so using SpecialPowers
> +  // allows us to use the ChromePowers object which we defined below.
> +  SpecialPowers._sendSyncMessage("Quitter.Quit", {});
> +};

This code duplication is a little :-(

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ffe9e4d56e6

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0ffe9e4d56e6