Closed Bug 693959 Opened 10 years ago Closed 10 years ago

convert quit.js to specialpowers

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: jmaher, Assigned: jmaher)

Details

(Whiteboard: [specialpowers][inbound])

Attachments

(1 file)

quit.js uses enable privilege and we need this to use specialpowers.
patch cleans up a lot of stuff now that we don't need ipc.js/ipc-overlay.xul.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #566489 - Flags: review?(ted.mielczarek)
Comment on attachment 566489 [details] [diff] [review]
port quit.js to specialpowers (1.0)

\o/
Comment on attachment 566489 [details] [diff] [review]
port quit.js to specialpowers (1.0)

Review of attachment 566489 [details] [diff] [review]:
-----------------------------------------------------------------

Lots of nice code removal. :)

::: testing/mochitest/specialpowers/components/SpecialPowersObserver.js
@@ +171,5 @@
>                    .messageManager
>                    .sendAsyncMessage("SPPingService", { op: "pong" });
>          }
>          break;
> +      case "Quitter.Quit":

You should probably rename this to SpecialPowers.Quit.

::: testing/mochitest/tests/SimpleTest/ChromePowers.js
@@ +104,5 @@
> +  // We come in here as SpecialPowers.quit, but SpecialPowers is really ChromePowers.
> +  // For some reason this.<func> resolves to TestRunner, so using SpecialPowers
> +  // allows us to use the ChromePowers object which we defined below.
> +  SpecialPowers._sendSyncMessage("Quitter.Quit", {});
> +};

This code duplication is a little :-(
Attachment #566489 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ffe9e4d56e6
Whiteboard: [specialpowers] → [specialpowers][inbound]
https://hg.mozilla.org/mozilla-central/rev/0ffe9e4d56e6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.