Last Comment Bug 694033 - Add Telemetry probes for windows which have had mutation event listeners
: Add Telemetry probes for windows which have had mutation event listeners
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-12 09:13 PDT by Olli Pettay [:smaug]
Modified: 2011-10-14 11:14 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.28 KB, patch)
2011-10-13 05:47 PDT, Olli Pettay [:smaug]
no flags Details | Diff | Review
patch (2.12 KB, patch)
2011-10-13 07:38 PDT, Olli Pettay [:smaug]
taras.mozilla: review+
Details | Diff | Review

Description Olli Pettay [:smaug] 2011-10-12 09:13:18 PDT
We could count how often documents have mutation event listeners.
If they are being used a lot, it may take some more time to get rid of
mutation events.
Comment 1 Olli Pettay [:smaug] 2011-10-12 09:14:44 PDT
So the outcome would be something like y of x created documents had mutation event listeners.
Comment 2 Olli Pettay [:smaug] 2011-10-13 05:47:13 PDT
Created attachment 566788 [details] [diff] [review]
patch

So I want to count how many (inner) windows have had mutation event listeners
and how many hasn't had.
Based on what about:telemetry reports, this does that.
Comment 3 Olli Pettay [:smaug] 2011-10-13 07:38:43 PDT
Created attachment 566812 [details] [diff] [review]
patch

Just a bit nicer coding style.
Comment 4 Jonas Sicking (:sicking) 2011-10-13 12:31:10 PDT
Can we please also let devs know that mutation events will get deprecated at some point? Even if we don't have a replacement for them yet, more information seems better than less. We can even provide an eta of when replacement will be available.
Comment 5 Olli Pettay [:smaug] 2011-10-13 12:34:28 PDT
Sure, but that has nothing to do with this bug :)
Comment 6 Sid Stamm [:geekboy or :sstamm] 2011-10-14 10:27:33 PDT
This is performance and usage-related, so fine privacy-wise.  Clearing the flag.
Comment 7 Olli Pettay [:smaug] 2011-10-14 11:14:30 PDT
https://hg.mozilla.org/mozilla-central/rev/45ac18984273

Note You need to log in before you can comment on or make changes to this bug.