Closed Bug 694135 Opened 8 years ago Closed 8 years ago

IndexedDB: Don't throw if there are unknown properties in the options objects to createObjectStore/createIndex

Categories

(Core :: DOM: IndexedDB, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sicking, Assigned: sicking)

References

Details

(Keywords: addon-compat, dev-doc-complete)

Attachments

(1 file)

Such properties should just be ignored.
Attached patch Patch to fixSplinter Review
This fixes things.

Turns out that "" is actually a valid key path and simply refers to the value itself. So it actually makes sense to use that on an objectStore which turns the store into a set.
Assignee: nobody → jonas
Attachment #572722 - Flags: review?(bent.mozilla)
Comment on attachment 572722 [details] [diff] [review]
Patch to fix

Review of attachment 572722 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #572722 - Flags: review?(bent.mozilla) → review+
Checked in https://hg.mozilla.org/mozilla-central/rev/e73f34291541

Thanks for the quick review!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
I've updated:
https://developer.mozilla.org/en/IndexedDB/IDBDatabase#section_12
https://developer.mozilla.org/en/IndexedDB/IDBObjectStore#section_15

and a mention in 
https://developer.mozilla.org/en/Firefox_10_for_developers

(Sidenote: the latest draft use a different type for passing the parameter, but I wasn't able to find a bug to adapt Firefox implementation)
Note that the fact that we don't implement dictionary types yet is not detectable from script; they are just specese to refer to simple JS objects, so I don't think the warnings are necessary.
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla10 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.