694160 - Investigate why enrolling into marketplace often fails with 'The PayPal third-party refund token on your account is invalid'

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

I have been using a test account on the PayPal sandbox and often enrolling into Marketplace fails with the error message 'The PayPal third-party refund token on your account is invalid'. Trying later usually is successful.

Let me know what other information I can provide to help you investigate.

Comment 1

[krupa raj[:krupa]]

screenshot at http://screencast.com/t/vhW0bbcBxnq

Comment 2

[krupa raj[:krupa]]

We should also check if the developer changes the email id after setting up the third-party token.

lengthy screencast: http://screencast.com/t/AZaK2nDbJnCz

Talk to me if the screencast is not clear.

Comment 3

[Allen Short [:ashort]]

After looking this over with Krupa I think we need to rework this interaction significantly. There's too many ways the state of the form and the paypal token state can get out of sync with each other. For example, Krupa added me as an author to an extension; I change the paypal ID for the addon to mine, set up my paypal refund token -- and then upon returning to the payments form, the previous paypal ID was still there, along with refund permissions for _my_ account. 

I think refund permissions need to be managed on a separate page or separate step from other Paypal-related info.

Comment 4

[Andy McKay]

I'm unsure how adding a separate page will help though. 

It sounds like the paypal_id didn't update correctly though from your comments? That would be an issue.

Comment 5

[Allen Short [:ashort]]

I discussed this with Andy and he suggested we move the refund-permissions link/notice to a notification as part of form validation, so nothing is even displayed about refund permissions if we have a valid token for them. The only downside I could see is that if ever the user deauthorized us for refunds, he would have to go to the payments form and submit it to see the link for setting that back up.

Comment 6

[Allen Short [:ashort]]

Refund token process moved to a message that only appears when not set up properly. Remaining issues covered in https://bugzilla.mozilla.org/show_bug.cgi?id=694685

https://github.com/mozilla/zamboni/commit/637fcfb776fb3170acb51b5244f5dc6d8ce1b78a#apps/devhub/views.py