Closed Bug 694164 Opened 11 years ago Closed 11 years ago

Fold mailABOverlay.xul into addressbook.xul

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
normal

Tracking

(seamonkey2.7 fixed)

RESOLVED FIXED
seamonkey2.7
Tracking Status
seamonkey2.7 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

Attachments

(1 file)

Currently we have mailABOverlay.xul overlaying a single file, addressbook.xul
Could simplify the code by folding this in.

This patch:
* Alters mac platformMailOverlay.xul to just overwrite the modifier
* Overlays addressbook.xul with platformMailOverlay.xul
* Adds mailOverlay.dtd entity to addressbook.xul
* Changes cmd_newmessage to cmd_newMessage in addressbook.xul
* Adds key_newMessage to addressbook.xul tasksKeys keyset
* Adds menu_newMessage to menu_NewPopup in addressbook.xul
* Removes mailABOverlay.xul and references to it
Attachment #566647 - Flags: review?(mnyromyr)
Comment on attachment 566647 [details] [diff] [review]
Fold in mailABOverlay [Checked in: Comment 2]

(In reply to Ian Neal from comment #0)
> This patch:
> * Alters mac platformMailOverlay.xul to just overwrite the modifier

That's not a good idea. If we need different keys on Mac, it often needs more than just changing the modifier.

r=me with that change not done.
Attachment #566647 - Flags: review?(mnyromyr) → review+
Comment on attachment 566647 [details] [diff] [review]
Fold in mailABOverlay [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/d30928e424c4
Attachment #566647 - Attachment description: Fold in mailABOverlay → Fold in mailABOverlay [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
You need to log in before you can comment on or make changes to this bug.