Search: Single match displays text "1 matches found"

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
--
minor
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: laurel, Assigned: Blake Ross)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Reporter)

Description

17 years ago
Using feb19 commercial trunk build

The display text for a single search result is "1 matches found".  The text
should be singular "1 match found".
(Reporter)

Updated

17 years ago
QA Contact: esther → laurel
Created attachment 25659 [details] [diff] [review]
Patch, please review.

Comment 2

17 years ago
Thank you Stephend. The patch looks great, except that the indentation for 
gStatusFeedback.showProgress(100) is changed in the patch. With that corrected, 
r=gayatrib
Status: NEW → ASSIGNED
Created attachment 25665 [details] [diff] [review]
New patch, fixes my broken spacing and corrects a string.

Comment 4

17 years ago
If you look a bit closer it looks like you're indenting using hard tabs where
the rest of the code uses 8 spaces. Please fix that :-) (Read the patch in
netscape/mozilla to see what I mean)

With that, r=jag (and r=gayatrib I guess).
Created attachment 25666 [details] [diff] [review]
Hopefully this fixed tabbing foo!

Comment 6

17 years ago
D'oh! I got distracted. I think it would be better to not do string building
like this in JS, but rather change the properties to read:
%S matches found
1 match found
and then use FormatStringFromName for the != 1 case.
http://bugzilla.mozilla.org/show_bug.cgi?id=69418
Bah, silly cut and paste error on that last comment.  Gayatrib, you had better
take this one out from here ;-)  Sorry I couldn't do more, guys ;(

Comment 9

17 years ago
Actually, r=jag on the patch as is, but let's open a new bug on fixing the
i18n/l10n problem here.
Seth, could you plant the wonderful two letters I like to see from you so much?
Thanks.

Comment 11

17 years ago
Created attachment 25670 [details] [diff] [review]
[patch] No, but this did

Comment 12

17 years ago
I should have looked, I should have looked ...
(Assignee)

Comment 13

17 years ago
Created attachment 25671 [details] [diff] [review]
[patch] use FormatStringFromName
gayatrib / jag, will you test / review out blake's patch?

it looks correct.  once we get a r=, I'll do the super review.

Comment 15

17 years ago
-            statusMsg = gNumOfSearchHits+"
"+Bundle.GetStringFromName("searchSuccessMessage");
+            statusMsg = FormatStringFromName("searchSuccessMessages",
[gNumOfSearchHits], 1);

That's missing |Bundle.|
(Assignee)

Comment 16

17 years ago
Created attachment 25724 [details] [diff] [review]
[patch] it sure is

Comment 17

17 years ago
I like this :-)

Of course, mao will kill you for merge hell ;-)

r=jag
(Assignee)

Comment 18

17 years ago
Seth, sr?
Assignee: gayatrib → blakeross
Status: ASSIGNED → NEW
gayatrib is the module owner for the search FE.

gayatrib, will you review this?

Comment 20

17 years ago
I had reviewed this before and had problem with bugzilla when i tried to commit 
my review. Sorry about the delay...
r=gayatrib
sr=sspitzer
(Assignee)

Updated

17 years ago
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 22

17 years ago
Checked in.
(Reporter)

Comment 23

17 years ago
OK using feb26 commercial trunk builds: linux rh6.0, mac OS 9.0, win98
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

Updated

9 years ago
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.