Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IonMonkey: Greedy regalloc bug in jit-test/tests/basic/testSwitch.js

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
jit-test/tests/basic/testSwitch.js:25: Error: Assertion failed: got 0, expected 226
(Assignee)

Comment 1

6 years ago
Created attachment 566910 [details] [diff] [review]
fix

The bug is that the COPY policy was evicting its own input, which is nonsense. All we have to do is spill.
(Assignee)

Updated

6 years ago
Attachment #566910 - Flags: review?(sstangl)
Comment on attachment 566910 [details] [diff] [review]
fix

Review of attachment 566910 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/GreedyAllocator.cpp
@@ +330,5 @@
>                  return false;
>              align(vr->reg(), reg);
>          } else {
> +            // Otherwise, just clobber the register, and restore it on the way
> +            // out.

If we remove the word " just", we can fit " out." on the same line.
Attachment #566910 - Flags: review?(sstangl) → review+
(Assignee)

Comment 3

6 years ago
Pushed w/ nit

http://hg.mozilla.org/projects/ionmonkey/rev/1e6e025df3d1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.