Last Comment Bug 694215 - IonMonkey: Greedy regalloc bug in jit-test/tests/basic/testSwitch.js
: IonMonkey: Greedy regalloc bug in jit-test/tests/basic/testSwitch.js
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-12 17:38 PDT by David Anderson [:dvander]
Modified: 2011-10-13 16:30 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.07 KB, patch)
2011-10-13 12:37 PDT, David Anderson [:dvander]
sstangl: review+
Details | Diff | Splinter Review

Description David Anderson [:dvander] 2011-10-12 17:38:19 PDT
jit-test/tests/basic/testSwitch.js:25: Error: Assertion failed: got 0, expected 226
Comment 1 David Anderson [:dvander] 2011-10-13 12:37:21 PDT
Created attachment 566910 [details] [diff] [review]
fix

The bug is that the COPY policy was evicting its own input, which is nonsense. All we have to do is spill.
Comment 2 Sean Stangl [:sstangl] 2011-10-13 16:13:40 PDT
Comment on attachment 566910 [details] [diff] [review]
fix

Review of attachment 566910 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/GreedyAllocator.cpp
@@ +330,5 @@
>                  return false;
>              align(vr->reg(), reg);
>          } else {
> +            // Otherwise, just clobber the register, and restore it on the way
> +            // out.

If we remove the word " just", we can fit " out." on the same line.
Comment 3 David Anderson [:dvander] 2011-10-13 16:30:36 PDT
Pushed w/ nit

http://hg.mozilla.org/projects/ionmonkey/rev/1e6e025df3d1

Note You need to log in before you can comment on or make changes to this bug.