Closed
Bug 694215
Opened 13 years ago
Closed 13 years ago
IonMonkey: Greedy regalloc bug in jit-test/tests/basic/testSwitch.js
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(1 file)
1.07 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
jit-test/tests/basic/testSwitch.js:25: Error: Assertion failed: got 0, expected 226
Assignee | ||
Comment 1•13 years ago
|
||
The bug is that the COPY policy was evicting its own input, which is nonsense. All we have to do is spill.
Assignee | ||
Updated•13 years ago
|
Attachment #566910 -
Flags: review?(sstangl)
Comment 2•13 years ago
|
||
Comment on attachment 566910 [details] [diff] [review] fix Review of attachment 566910 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/GreedyAllocator.cpp @@ +330,5 @@ > return false; > align(vr->reg(), reg); > } else { > + // Otherwise, just clobber the register, and restore it on the way > + // out. If we remove the word " just", we can fit " out." on the same line.
Attachment #566910 -
Flags: review?(sstangl) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed w/ nit http://hg.mozilla.org/projects/ionmonkey/rev/1e6e025df3d1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•