Closed Bug 694231 Opened 13 years ago Closed 13 years ago

Remove VMCFG_METHODENV_IMPL32

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edwsmith, Assigned: edwsmith)

References

Details

Attachments

(1 file)

This config flag controls whether MethodEnv gets an invocation pointer or not.  Its only off in interpreter-only builds.  It saves a trivial amount of memory in such builds, but costs by complicating the codebase.

Its always on in JIT and AOT configurations.
Attachment #566723 - Attachment is patch: true
Blocks: halfmoon
Attachment #566723 - Flags: review?(wmaddox)
Assignee: nobody → edwsmith
Depends on: 537926
Blocks: 537926
No longer depends on: 537926
Comment on attachment 566723 [details] [diff] [review]
Remove flag (enabled always).

This seems like a harmless change, but it's not removing much complexity either.  I presume this is preliminary to some more significant revisions to exec.cpp?
Attachment #566723 - Flags: review?(wmaddox) → review+
Every little bit counts.  It's certian we'll need to do more to manage what the code pointers actually point to over their lifetime, both in MethodEnv and MethodInfo.
changeset: 6667:8d0f76b43b07
user:      Edwin Smith <edwsmith@adobe.com>
summary:   Bug 694231 - Remove VMCFG_METHODENV_IMPL32 (r=wmaddox+)

http://hg.mozilla.org/tamarin-redux/rev/8d0f76b43b07
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: