Closed Bug 694241 Opened 8 years ago Closed 8 years ago

devicemanagerADB has error in getDirectory causing remotereftest failures

Categories

(Testing :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

after adding in the ability to pull minidumps from the device (tested and deployed with SUT), we now fail with ADB to run fennec.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #566732 - Flags: review?(wlachance)
this patch should fix the errors that mjrosenb and khuey were seeing while trying to run reftests on android.
Blocks: 694299
Comment on attachment 566732 [details] [diff] [review]
allow getdirectory to get a blank directory (1.0)

+    if (len(ret) > 0):
+      ret.pop(len(ret) - 1)

Looks fine, you could replace ret.pop(len(ret) - 1) with just ret.pop() for extra cleanup points.
Attachment #566732 - Flags: review+
Attachment #566732 - Flags: review?(wlachance)
https://hg.mozilla.org/mozilla-central/rev/d51f0976b61e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Component: Infrastructure → General
You need to log in before you can comment on or make changes to this bug.