Closed
Bug 694241
Opened 13 years ago
Closed 13 years ago
devicemanagerADB has error in getDirectory causing remotereftest failures
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
719 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
after adding in the ability to pull minidumps from the device (tested and deployed with SUT), we now fail with ADB to run fennec.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
this patch should fix the errors that mjrosenb and khuey were seeing while trying to run reftests on android.
You are my hero.
Comment 4•13 years ago
|
||
Comment on attachment 566732 [details] [diff] [review] allow getdirectory to get a blank directory (1.0) + if (len(ret) > 0): + ret.pop(len(ret) - 1) Looks fine, you could replace ret.pop(len(ret) - 1) with just ret.pop() for extra cleanup points.
Attachment #566732 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Attachment #566732 -
Flags: review?(wlachance)
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d51f0976b61e
Whiteboard: [inbound]
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d51f0976b61e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Updated•11 years ago
|
Component: Infrastructure → General
You need to log in
before you can comment on or make changes to this bug.
Description
•