Closed Bug 694298 Opened 10 years ago Closed 10 years ago

Changing SVG text to empty doesn't repaint

Categories

(Core :: SVG, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: paroga, Assigned: longsonr)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files, 1 obsolete file)

Attached image Testcase
No description provided.
Status: UNCONFIRMED → NEW
Depends on: 655025
Ever confirmed: true
Keywords: regression, testcase
Attached patch patch (obsolete) — Splinter Review
We now skip glyph frames that don't contain any text when we layout the text. Of course if the glyph did once contain text and now doesn't then we end up skipping clearing it.
Assignee: nobody → longsonr
Attachment #566805 - Flags: review?(dholbert)
OS: Windows 7 → All
Hardware: x86_64 → All
Blocks: 655025
No longer depends on: 655025
Comment on attachment 566805 [details] [diff] [review]
patch

>diff --git a/layout/reftests/svg/reftest.list b/layout/reftests/svg/reftest.list
>+== dynamic-text-05.svg pass.svg

>diff --git a/layout/reftests/svg/script-empty-01.svg b/layout/reftests/svg/script-empty-01.svg
[...]
>+  <title>Testcase for that xlink:href attribute overrides script content</title>

Looks like you |hg add|'ed the wrong test file.  (dynamic-text-05 vs script-empty-01.svg

r=me with that fixed. (I'll trust that dynamic-text-05.svg is sane. :) )
Attachment #566805 - Flags: review?(dholbert) → review+
Attachment #566805 - Attachment is obsolete: true
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/de59e7adc9f6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.