694298 - Changing SVG text to empty doesn't repaint

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Patrick R. Gansterer]

Attachment: Testcase

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

We now skip glyph frames that don't contain any text when we layout the text. Of course if the glyph did once contain text and now doesn't then we end up skipping clearing it.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 566805 [details] [diff] [review]
patch

>diff --git a/layout/reftests/svg/reftest.list b/layout/reftests/svg/reftest.list
>+== dynamic-text-05.svg pass.svg

>diff --git a/layout/reftests/svg/script-empty-01.svg b/layout/reftests/svg/script-empty-01.svg
[...]
>+  <title>Testcase for that xlink:href attribute overrides script content</title>

Looks like you |hg add|'ed the wrong test file.  (dynamic-text-05 vs script-empty-01.svg

r=me with that fixed. (I'll trust that dynamic-text-05.svg is sane. :) )

Comment 3

[Robert Longson [:longsonr]]

Attachment: with the right reftest this time

Comment 4

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/de59e7adc9f6

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/de59e7adc9f6