Changing SVG text to empty doesn't repaint

RESOLVED FIXED in mozilla10

Status

()

Core
SVG
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Patrick R. Gansterer, Assigned: Robert Longson)

Tracking

({regression, testcase})

Trunk
mozilla10
regression, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 566792 [details]
Testcase
(Assignee)

Updated

6 years ago
Status: UNCONFIRMED → NEW
Depends on: 655025
Ever confirmed: true
Keywords: regression, testcase
(Assignee)

Comment 1

6 years ago
Created attachment 566805 [details] [diff] [review]
patch

We now skip glyph frames that don't contain any text when we layout the text. Of course if the glyph did once contain text and now doesn't then we end up skipping clearing it.
Assignee: nobody → longsonr
Attachment #566805 - Flags: review?(dholbert)
(Assignee)

Updated

6 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Blocks: 655025
No longer depends on: 655025
Comment on attachment 566805 [details] [diff] [review]
patch

>diff --git a/layout/reftests/svg/reftest.list b/layout/reftests/svg/reftest.list
>+== dynamic-text-05.svg pass.svg

>diff --git a/layout/reftests/svg/script-empty-01.svg b/layout/reftests/svg/script-empty-01.svg
[...]
>+  <title>Testcase for that xlink:href attribute overrides script content</title>

Looks like you |hg add|'ed the wrong test file.  (dynamic-text-05 vs script-empty-01.svg

r=me with that fixed. (I'll trust that dynamic-text-05.svg is sane. :) )
Attachment #566805 - Flags: review?(dholbert) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 567060 [details] [diff] [review]
with the right reftest this time
Attachment #566805 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/de59e7adc9f6
Severity: major → minor
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/de59e7adc9f6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.