Closed
Bug 694327
Opened 14 years ago
Closed 14 years ago
mozrunner.wait() should allow outputTimeouts
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(1 file)
|
774 bytes,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
Currently mozrunner.wait only accepts a timeout parameter, but it should also take an outputTimeout one.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #566825 -
Flags: review?(jhammel)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 566825 [details] [diff] [review]
Patch 1.0 - Allow mozrunner to use outputTimeout
r+, though alternatively you could take one parameter and pass
.waitForFinish(timeout=timeout, outputTimeout=timeout)
Attachment #566825 -
Flags: review?(jhammel) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
That way actually wouldn't work since in mozprocess timeout takes precedence over outputTimeout.
master: https://github.com/mozautomation/mozmill/commit/f2e3405c6e055454bd6a9afe3e0492ff128ea113
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•