Move linux-mips CXX, CC, LD and AR exports to environment.sh and change BuildShellCommand call to simpler compile_generic call.

VERIFIED FIXED in Q1 12 - Brannan

Status

Tamarin
Build Config
P4
normal
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: James Sudduth, Assigned: James Sudduth)

Tracking

unspecified
Q1 12 - Brannan
x86
Linux
Bug Flags:
in-testsuite -
flashplayer-injection -
flashplayer-qrb -
flashplayer-bug -
flashplayer-triage -

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The only compile step that is still exporting CXX, CC, LD and AR from the BuildShellCommand call in tamarinredux.py is the linux-mips compile. This can be brought into conformance with other platforms and simplified by exporting these env vars from the linux-mips environment.sh and changing the BuildShellCommand call in tamarinredux.py to a compile_generic call.
Flags: in-testsuite-
Flags: flashplayer-triage-
Flags: flashplayer-qrb-
Flags: flashplayer-injection-
Flags: flashplayer-bug-
(Assignee)

Comment 1

7 years ago
Created attachment 566921 [details] [diff] [review]
Move CXX, CC, LD and AR compile vars out of tamarinredux.py and sandbox.py
Attachment #566921 - Flags: review?(brbaker)

Comment 2

7 years ago
Comment on attachment 566921 [details] [diff] [review]
Move CXX, CC, LD and AR compile vars out of tamarinredux.py and sandbox.py

Review of attachment 566921 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Looked like there was a little bit of another patch that slipped in in the environment.sh change (looks like part of the AOT change, but is fine)
Attachment #566921 - Flags: review?(brbaker) → review+

Comment 3

7 years ago
changeset: 6645:f0480243bb90
user:      James Sudduth <jsudduth@adobe.com>
summary:   Bug 694349 - Move linux-mips CCX, CC, LD and AR exports to environment.sh and change BuildShellCommand call to simpler compile_generic call (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/f0480243bb90

Comment 4

7 years ago
changeset: 6650:6d9c0d326513
user:      James Sudduth <jsudduth@adobe.com>
summary:   Bug 694349 - Move linux-mips CCX, CC, LD and AR exports to environment.sh and change BuildShellCommand call to simpler compile_generic call - fix typos (r=jsudduth

http://hg.mozilla.org/tamarin-redux/rev/6d9c0d326513
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Summary: Move linux-mips CCX, CC, LD and AR exports to environment.sh and change BuildShellCommand call to simpler compile_generic call. → Move linux-mips CXX, CC, LD and AR exports to environment.sh and change BuildShellCommand call to simpler compile_generic call.
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.