Closed Bug 694360 Opened 12 years ago Closed 12 years ago

Permit unicode escape sequences in keywords (thi\u0073 is a keyword, not an identifier)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: jorendorff, Assigned: evilpie)

Details

Attachments

(1 file)

v1 detect unicode escaped keywords
7.26 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review 
This should be a SyntaxError:
  var thi\u0073;
Currently we permit it and actually declare a variable named "this" (although we ban it in strict mode, apparently by accident rather than by design).

See discussion here:
  https://mail.mozilla.org/pipermail/es-discuss/2011-June/015389.html

The most persuasive response was Allen Wirfs-Brock's interpretation of ES5:
  https://mail.mozilla.org/pipermail/es-discuss/2011-June/015422.html

No one really disagreed.

        Attachment #567474 -
        Flags: review?(jorendorff)

    
    

    
  
Comment on attachment 567474 [details] [diff] [review]
v1 detect unicode escaped keywords

throws() has a bug: if eval(code) does not throw, the test passes.

r=me with that fixed. Thanks!

        Attachment #567474 -
        Flags: review?(jorendorff) → review+

    
  
Assignee: general → evilpies

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/56c27cde0643
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

          You need to log in
          before you can comment on or make changes to this bug.