Last Comment Bug 694371 - [c-c] "Warning: package error or possible missing or unnecessary file:" : 4 "VC80" files. (WIN32_REDIST_DIR is needed again.)
: [c-c] "Warning: package error or possible missing or unnecessary file:" : 4 "...
Status: RESOLVED FIXED
[fixed in comm10a1: Bv1, SMv2.8a1: Av...
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows Server 2003
: -- major (vote)
: Thunderbird 13.0
Assigned To: Justin Wood (:Callek) (Away until Aug 29)
:
Mentors:
Depends on: 673197 678161 678195 681893 696422 712528 712960
Blocks: 713134
  Show dependency treegraph
 
Reported: 2011-10-13 11:26 PDT by Serge Gautherie (:sgautherie)
Modified: 2012-02-29 08:32 PST (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
-
wontfix
-
wontfix
fixed
fixed


Attachments
(Av1-SM) removed-files.in: Use != (as in m-c bug 681893) instead of == [Checked in: Comment 14] (1.66 KB, patch)
2011-10-21 09:54 PDT, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review
(Bv1) autoconf.mk.in: Remove leftover WIN32_CRT_SRC_DIR from bug 678195 port [Checked in: Comment 10] (804 bytes, patch)
2011-10-21 11:36 PDT, Serge Gautherie (:sgautherie)
standard8: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-10-13 11:26:10 PDT
In addition to (FF) bug 694353, SeaMonkey has the following warnings:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1318429599.1318448919.16271.gz
WINNT 5.2 comm-central-trunk build on 2011/10/12 07:26:39
{
Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 45).
Warning: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 46).
Warning: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 47).
Warning: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 48).
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1315926742.1315943040.15790.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2011/09/13 08:12:22
already had this bug.

***

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1318446822.1318464400.17544.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/10/12 12:13:42
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1317275406.1317286128.26055.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/09/28 22:50:06
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1317184843.1317202181.6362.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/09/27 21:40:43
rev:0a289bc5e5ea
moz:91108b393572
already had this bug.

http://hg.mozilla.org/releases/comm-aurora/pushloghtml?fromchange=82bbc61f708b&tochange=0a289bc5e5ea
(big) Merge from comm-central :-/
http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=9b32a50de895&tochange=91108b393572
(huge) Merge from mozilla-central :-/
Searching for "MSVC", I'm guessing at bug 678161 or the like.
Mike, could you confirm ?

(2 red builds in-between)

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1317051655.1317060069.6921.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/09/26 08:40:55
rev:82bbc61f708b
moz:9b32a50de895
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1317024198.1317038300.26629.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/09/26 01:03:18
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1316622260.1316636019.27612.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/09/21 09:24:20
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1315949173.1315963663.10027.gz&fulltext=1
WINNT 5.2 comm-aurora build on 2011/09/13 14:26:13
didn't have this bug.

***

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1318385590.1318397671.23631.gz&fulltext=1
WINNT 5.2 comm-beta build on 2011/10/11 19:13:10
doesn't have this bug.
Comment 1 Mike Hommey [:glandium] 2011-10-13 11:34:48 PDT
Yes, that and the subsequent jemalloc/mozutils related changes.
Comment 2 Serge Gautherie (:sgautherie) 2011-10-21 08:41:35 PDT
Hum, another changeset without a bug number :-/
{
bugzilla@standard8.plus.com
Thu Aug 25 12:14:41 2011 -0700
http://hg.mozilla.org/comm-central/rev/eebfdbc18e61
Port bug 678161, bug 673197, bug 678195 to fix windows bustage - fix SeaMonkey manifests. rs=Callek
}

From what I've seen so far:
bug 678161 and bug 681893 are what I had started to look at.
I was going to look at bug 678195 too.
I'll have to look how bug 673197 fits in.
Comment 3 Serge Gautherie (:sgautherie) 2011-10-21 09:11:33 PDT
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Hum, another changeset without a bug number :-/

Oh, that was actually a follow-up to another similar changeset :-/
{
bugzilla@standard8.plus.com
Thu Aug 25 04:46:43 2011 -0700
http://hg.mozilla.org/comm-central/rev/fb9e7f177a7e
Port bug 678161, bug 673197, bug 678195 to fix windows bustage. r=bustage-fix for CLOSED TREE
}
Comment 4 Serge Gautherie (:sgautherie) 2011-10-21 09:54:07 PDT
Created attachment 568694 [details] [diff] [review]
(Av1-SM) removed-files.in: Use != (as in m-c bug 681893) instead of ==
[Checked in: Comment 14]

This way is simpler and prepares for adding VC 11 support.
Comment 5 Serge Gautherie (:sgautherie) 2011-10-21 10:37:30 PDT
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> bug 678161 and bug 681893 are what I had started to look at.

Port of these bugs looks fine (with filed "Core" bug 696422).
Comment 6 Serge Gautherie (:sgautherie) 2011-10-21 11:36:40 PDT
Created attachment 568717 [details] [diff] [review]
(Bv1) autoconf.mk.in: Remove leftover WIN32_CRT_SRC_DIR from bug 678195 port
[Checked in: Comment 10]

Trivial missed cleanup.
Comment 7 Serge Gautherie (:sgautherie) 2011-10-21 11:43:27 PDT
(In reply to Serge Gautherie (:sgautherie) from comment #2)

> I was going to look at bug 678195 too.

Port of this bug looks fine (with attached patch Bv1).

> I'll have to look how bug 673197 fits in.

Port of this bug looks fine.

***

I need to continue searching...
Comment 8 Mark Banner (:standard8) 2011-10-21 23:15:49 PDT
Comment on attachment 568717 [details] [diff] [review]
(Bv1) autoconf.mk.in: Remove leftover WIN32_CRT_SRC_DIR from bug 678195 port
[Checked in: Comment 10]

r=me though I'd really prefer these on a mailnews core bug, and its only vaguely related tovthis bug.
Comment 9 Serge Gautherie (:sgautherie) 2011-10-22 04:59:30 PDT
Thunderbird has this bug too:

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1319234499.1319259055.25890.gz&fulltext=1
WINNT 5.2 comm-central build on 2011/10/21 15:01:39
{
Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 29).
Warning: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 30).
Warning: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 31).
Warning: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 32).
}
Comment 10 Serge Gautherie (:sgautherie) 2011-10-22 05:06:37 PDT
Comment on attachment 568717 [details] [diff] [review]
(Bv1) autoconf.mk.in: Remove leftover WIN32_CRT_SRC_DIR from bug 678195 port
[Checked in: Comment 10]

http://hg.mozilla.org/comm-central/rev/543d72f7ebf5
Comment 11 Serge Gautherie (:sgautherie) 2011-11-22 07:12:36 PST
Comment on attachment 568694 [details] [diff] [review]
(Av1-SM) removed-files.in: Use != (as in m-c bug 681893) instead of ==
[Checked in: Comment 14]

Callek (or KaiRo), ping for review.
Comment 12 Robert Kaiser 2011-11-26 17:15:40 PST
Comment on attachment 568694 [details] [diff] [review]
(Av1-SM) removed-files.in: Use != (as in m-c bug 681893) instead of ==
[Checked in: Comment 14]

Review of attachment 568694 [details] [diff] [review]:
-----------------------------------------------------------------

I'll leave this one to Callek as I'm pretty much out of the loop on what we are doing for MSVC runtime libraries nowadays, and what we'll need with the switch to MSVC2010 coming along.
Comment 13 Justin Wood (:Callek) (Away until Aug 29) 2011-12-01 14:00:36 PST
Comment on attachment 568694 [details] [diff] [review]
(Av1-SM) removed-files.in: Use != (as in m-c bug 681893) instead of ==
[Checked in: Comment 14]

Sorry for the delay serge, looks good!

While you're here, rs+ for the block for MSVC11 (#if _MSC_VER != 1700)
Comment 14 Serge Gautherie (:sgautherie) 2011-12-01 16:33:56 PST
Comment on attachment 568694 [details] [diff] [review]
(Av1-SM) removed-files.in: Use != (as in m-c bug 681893) instead of ==
[Checked in: Comment 14]

http://hg.mozilla.org/comm-central/rev/5e2c9c9d03b5


(In reply to Justin Wood (:Callek) from comment #13)
> While you're here, rs+ for the block for MSVC11 (#if _MSC_VER != 1700)

Done in bug 707021.
Comment 15 Serge Gautherie (:sgautherie) 2011-12-02 17:49:22 PST
Ah, I checked a bunch of SeaMonkey trunk logs for Win_opt and Win_nightly.

It looks like this could be affecting (only) some "builders":
at first glance, it would look like
*cb-sea-win32-tbox (nightly) was fixed after 23_17h and before 30_06h.
*cb-seamonkey-win32-0[123] are fine.
*cn-sea-qm-win2k3-01 (both) is still affected.

Let's check whether a clobber fixes this bug: I requested it
for cn-sea-qm-win2k3-01 'build' and 'nightly' on 2011-12-02 17:33:29 PST...
Comment 16 Serge Gautherie (:sgautherie) 2011-12-03 09:43:21 PST
(In reply to Serge Gautherie (:sgautherie) from comment #15)
> Let's check whether a clobber fixes this bug: I requested it
> for cn-sea-qm-win2k3-01 'build' and 'nightly' on 2011-12-02 17:33:29 PST...

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1322888359.1322903828.31207.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2011/12/02 20:59:19
{
Building on: cn-sea-qm-win2k3-01

comm-cen-trunk-w32:Our last clobber date:  2011-12-02 17:33:29
comm-cen-trunk-w32:Server clobber date:    2011-12-02 17:33:29
comm-cen-trunk-w32-ntly:Our last clobber date:  2011-12-02 17:33:29
comm-cen-trunk-w32-ntly:Server clobber date:    2011-12-02 17:33:29

[Bug still there]
}

Iiuc, cloberring action is not explicitly noted anywhere (and there was no other build on this builder in the meantime.
Callek, was clobber actually done? How can "I" know that? Can you check it?
If clobber did happen, then I would assume this builder(s) is somehow misconfigured... Can you check that?
Comment 17 Justin Wood (:Callek) (Away until Aug 29) 2011-12-09 13:27:20 PST
(In reply to Serge Gautherie (:sgautherie) from comment #16)
> Iiuc, cloberring action is not explicitly noted anywhere (and there was no
> other build on this builder in the meantime.
> Callek, was clobber actually done? How can "I" know that? Can you check it?
> If clobber did happen, then I would assume this builder(s) is somehow
> misconfigured... Can you check that?

I know I won't be able to check that builder by our last 2.6 build. Sorry.
Comment 18 Serge Gautherie (:sgautherie) 2012-01-01 07:12:23 PST
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1325395137.1325414342.5676.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2011/12/31 21:18:57
s: cb-sea-win32-tbox

(still) has this bug (too).
Comment 19 Serge Gautherie (:sgautherie) 2012-01-01 09:46:48 PST
(In reply to Serge Gautherie (:sgautherie) from comment #18)
> s: cb-sea-win32-tbox
> 
> (still) has this bug (too).

I'm not sure whether this case is an old or new error.

***

(Mark,) It looks like SeaMonkey needs to port TB bug 712960, doesn't it?
(Justin,) Or would bug 714495 (or the like) supersede bug 712960 (and the current one)?
Comment 20 Justin Wood (:Callek) (Away until Aug 29) 2012-01-01 16:40:53 PST
(In reply to Serge Gautherie (:sgautherie) from comment #19)
> (In reply to Serge Gautherie (:sgautherie) from comment #18)
> > s: cb-sea-win32-tbox
> > 
> > (still) has this bug (too).
> 
> I'm not sure whether this case is an old or new error.
> 
> ***
> 
> (Mark,) It looks like SeaMonkey needs to port TB bug 712960, doesn't it?

No we don't, we just need to make sure that we export that data the same way as our other win32 boxes.

> (Justin,) Or would bug 714495 (or the like) supersede bug 712960 (and the
> current one)?

That bug is a different issue.
Comment 21 Serge Gautherie (:sgautherie) 2012-01-08 08:10:59 PST
(In reply to Justin Wood (:Callek) from comment #17)
> I know I won't be able to check that builder by our last 2.6 build. Sorry.

/pub/mozilla.org/seamonkey/releases/2.6/win32/en-US
seamonkey-2.6.zip
/pub/mozilla.org/seamonkey/releases/2.6.1/win32/en-US
seamonkey-2.6.1.zip

both include these 4 files :-)
(Hopefully, we were safe for all locales of these releases.)
Comment 22 Serge Gautherie (:sgautherie) 2012-01-10 22:13:02 PST
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> http://hg.mozilla.org/comm-central/rev/eebfdbc18e61
> Port bug 678161, bug 673197, bug 678195 to fix windows bustage - fix
> SeaMonkey manifests. rs=Callek

(In reply to Justin Wood (:Callek) from comment #20)
> (In reply to Serge Gautherie (:sgautherie) from comment #19)
> > (Mark,) It looks like SeaMonkey needs to port TB bug 712960, doesn't it?
> 
> No we don't, we just need to make sure that we export that data the same way
> as our other win32 boxes.

Ftr,
https://developer.mozilla.org/en/Windows_Build_Prerequisites#section_10
{
If you intend to distribute your build to others, and you have not built with --enable-jemalloc, you will need to set WIN32_REDIST_DIR=$VCINSTALLDIR\redist\x86\Microsoft.VC80.CRT in your mozconfig to get the Microsoft CRT DLLs packaged along with the application.
}
though, per bug 712960, that may (now) be needed even with --enable-jemalloc.
(See comment 2 quoted changeset.)

***

Mike, that DMO page needs updating, right?
Comment 23 Mike Hommey [:glandium] 2012-01-10 23:22:15 PST
(In reply to Serge Gautherie (:sgautherie) from comment #22)
> Mike, that DMO page needs updating, right?

Indeed. I updated it.
Comment 24 Serge Gautherie (:sgautherie) 2012-01-11 09:03:08 PST
(In reply to Mike Hommey [:glandium] from comment #23)
> (In reply to Serge Gautherie (:sgautherie) from comment #22)
> > Mike, that DMO page needs updating, right?
> 
> Indeed. I updated it.

Thanks, I restored old case (ftr), so it now reads:
{
If you intend to distribute your build to others, you will need to set WIN32_REDIST_DIR=$VCINSTALLDIR\redist\x86\Microsoft.VC80.CRT in your mozconfig to get the Microsoft CRT DLLs packaged along with the application.
    * Prior to Gecko 9 (FF 9, SM 2.6, TB 9) , this was needed only if you had not built with --enable-jemalloc.
}
Comment 25 Serge Gautherie (:sgautherie) 2012-01-18 18:36:18 PST
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=3097e9c39214

This bug is not reproducible on MoMe Try as the latter defines WIN32_REDIST_DIR (on opt builds).

All other (real) blockers of SM bug 713134 have patches (to review) now.

*****

(In reply to Justin Wood (:Callek) from comment #20)
> (In reply to Serge Gautherie (:sgautherie) from comment #19)
> > (Mark,) It looks like SeaMonkey needs to port TB bug 712960, doesn't it?
> 
> No we don't, we just need to make sure that we export that data the same way
> as our other win32 boxes.

http://mxr.mozilla.org/build/search?string=WIN32_REDIST_DIR&case=on
'thunderbird/win32', 'mozilla2/win32-mobile' and 'mozilla2/mobile/win32-i686' do it from their 'nightly' and 'release' mozconfigs.

Other builds (like Firefox) must do it otherwise. (Set in Windows environment? Or in a script?)
Comment 26 Serge Gautherie (:sgautherie) 2012-01-30 03:02:45 PST
(In reply to Serge Gautherie (:sgautherie) from comment #25)
> All other (real) blockers of SM bug 713134 have patches (to review) now.

There are all fixed atm. Blocked by this bug only now...
Comment 27 Serge Gautherie (:sgautherie) 2012-02-05 11:00:39 PST
(In reply to Serge Gautherie (:sgautherie) from comment #21)

> /pub/mozilla.org/seamonkey/releases/2.6.1/win32/en-US
> seamonkey-2.6.1.zip

and
/pub/mozilla.org/seamonkey/releases/2.7/win32/en-US
seamonkey-2.7.zip

> both include these 4 files :-)
> (Hopefully, we were safe for all locales of these releases.)
Comment 28 Serge Gautherie (:sgautherie) 2012-02-16 09:23:57 PST
(In reply to Serge Gautherie (:sgautherie) from comment #27)
> /pub/mozilla.org/seamonkey/releases/2.7/win32/en-US
> seamonkey-2.7.zip

and
/pub/mozilla.org/seamonkey/releases/2.7.1/win32/en-US
seamonkey-2.7.1.zip

> > both include these 4 files :-)
> > (Hopefully, we were safe for all locales of these releases.)
Comment 29 Serge Gautherie (:sgautherie) 2012-02-18 23:52:17 PST
/mozilla.org/seamonkey/releases/2.7.2/win32/en-US
seamonkey-2.7.2.zip
includes these 4 files :-)
Comment 30 Justin Wood (:Callek) (Away until Aug 29) 2012-02-19 08:54:32 PST
Fixed up:

cb-sea-win32-tbox
cn-sea-qm-win2k3-01

They need to actually reboot before this fix goes into affect, but they should within the day.

Note You need to log in before you can comment on or make changes to this bug.