Closed
Bug 694409
Opened 13 years ago
Closed 13 years ago
Suppress Telemetry notification on Mozmill tests
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(thunderbird9 fixed)
RESOLVED
FIXED
Thunderbird 10.0
Tracking | Status | |
---|---|---|
thunderbird9 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
Details
Attachments
(1 file, 1 obsolete file)
1.64 KB,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
In the same vein as bug 638605, we don't want the Telemetry opt-in prompt in our Mozmill tests.
Assignee | ||
Comment 1•13 years ago
|
||
Comment on attachment 566930 [details] [diff] [review] Patch v1 On a side note, there's a least one case (bug 690319) where the Telemetry prompt caused some focus issues, thus leading to some random oranges. This patch *might* clear some of the oranges that have been cropping up lately.
Attachment #566930 -
Flags: review?(sagarwal)
Attachment #566930 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•13 years ago
|
Attachment #566930 -
Attachment is patch: true
Assignee | ||
Comment 2•13 years ago
|
||
Oh, and there are some Try builds here: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=cdc77ddb3fe6
Comment 3•13 years ago
|
||
Comment on attachment 566930 [details] [diff] [review] Patch v1 wrong flag ;-)
Attachment #566930 -
Flags: approval-mozilla-aurora? → approval-comm-aurora?
Assignee | ||
Comment 4•13 years ago
|
||
Whoops, thanks!
Comment 5•13 years ago
|
||
Comment on attachment 566930 [details] [diff] [review] Patch v1 Actually, thinking about this, you should update the prefs.js in the migration-from-tb2 sub-directory, as well as the runtest.py for the bloat tests.
Assignee | ||
Comment 6•13 years ago
|
||
Thanks for pointing out those other pref points - I've added the prefs where you suggested.
Assignee: nobody → mconley
Attachment #566930 -
Attachment is obsolete: true
Attachment #566930 -
Flags: review?(sagarwal)
Attachment #566930 -
Flags: approval-comm-aurora?
Attachment #567082 -
Flags: review?(mbanner)
Attachment #567082 -
Flags: approval-comm-aurora?
Updated•13 years ago
|
Attachment #567082 -
Flags: review?(mbanner)
Attachment #567082 -
Flags: review+
Attachment #567082 -
Flags: approval-comm-aurora?
Attachment #567082 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 7•13 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/fd03acbff68a Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/cab170bfadec
Status: NEW → RESOLVED
Closed: 13 years ago
status-thunderbird9:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in
before you can comment on or make changes to this bug.
Description
•