Closed Bug 694409 Opened 13 years ago Closed 13 years ago

Suppress Telemetry notification on Mozmill tests

Categories

(Thunderbird :: Testing Infrastructure, defect)

x86
All
defect
Not set
normal

Tracking

(thunderbird9 fixed)

RESOLVED FIXED
Thunderbird 10.0
Tracking Status
thunderbird9 --- fixed

People

(Reporter: mconley, Assigned: mconley)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
In the same vein as bug 638605, we don't want the Telemetry opt-in prompt in our Mozmill tests.
Comment on attachment 566930 [details] [diff] [review]
Patch v1

On a side note, there's a least one case (bug 690319) where the Telemetry prompt caused some focus issues, thus leading to some random oranges.  This patch *might* clear some of the oranges that have been cropping up lately.
Attachment #566930 - Flags: review?(sagarwal)
Attachment #566930 - Flags: approval-mozilla-aurora?
Attachment #566930 - Attachment is patch: true
Comment on attachment 566930 [details] [diff] [review]
Patch v1

wrong flag ;-)
Attachment #566930 - Flags: approval-mozilla-aurora? → approval-comm-aurora?
Whoops, thanks!
Comment on attachment 566930 [details] [diff] [review]
Patch v1

Actually, thinking about this, you should update the prefs.js in the migration-from-tb2 sub-directory, as well as the runtest.py for the bloat tests.
Attached patch Patch v2Splinter Review
Thanks for pointing out those other pref points - I've added the prefs where you suggested.
Assignee: nobody → mconley
Attachment #566930 - Attachment is obsolete: true
Attachment #566930 - Flags: review?(sagarwal)
Attachment #566930 - Flags: approval-comm-aurora?
Attachment #567082 - Flags: review?(mbanner)
Attachment #567082 - Flags: approval-comm-aurora?
Attachment #567082 - Flags: review?(mbanner)
Attachment #567082 - Flags: review+
Attachment #567082 - Flags: approval-comm-aurora?
Attachment #567082 - Flags: approval-comm-aurora+
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/fd03acbff68a

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/cab170bfadec
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.