Closed Bug 694434 Opened 8 years ago Closed 8 years ago

Non-ASCII filename on statistics overlay shows as escaped unicode

Categories

(Toolkit :: Video/Audio Controls, defect, minor)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla10

People

(Reporter: unghost, Assigned: nawitus)

References

Details

(Keywords: verified-beta, Whiteboard: [good first bug][mentor=jwein][qa!])

Attachments

(2 files)

Attached image Screenshot of the bug
STR:
1) Give video file Non-ASCII filename, for example: Basilique du Sacré-Cœur de Montmartre.ogg
2) Play this file in Firefox
3) Open statistics overlay during play

Expected results: Media field contains "Basilique du Sacré-Cœur de Montmartre.ogg"
Actual results: Media field contains "Basilique%20du%20Sacr%C3%A9-C%C5%93ur%20de%20Montmartre.ogg"

It looks really ugly.
Whiteboard: [good first bug][mentor=jwein]
In /toolkit/content/widgets/videocontrols.xml, we will need to do some type of escaping when we set the textContent so that the text isn't mangled and still displays non-ASCII text correctly.
Depends on: 669260
Fixed using the decodeURI function in videocontrols.xml.
Attachment #569469 - Flags: review?(jwein)
Comment on attachment 569469 [details] [diff] [review]
Patch to fix bug 694434.

Untested, but it looks good to me. Forwarding to Justin for review.

Thanks for your first patch :)
Attachment #569469 - Flags: review?(jwein)
Attachment #569469 - Flags: review?(dolske)
Attachment #569469 - Flags: feedback+
Comment on attachment 569469 [details] [diff] [review]
Patch to fix bug 694434.

Review of attachment 569469 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, thanks for the patch!
Attachment #569469 - Flags: review?(dolske) → review+
Jared, can you (or someone else) push the code into the tree?
Marking as checkin-needed in case someone else checks it in before I do.
Assignee: nobody → nawitus
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/06e8e34e0abe
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jwein] → [good first bug][mentor=jwein][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/06e8e34e0abe
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jwein][fixed-in-fx-team] → [good first bug][mentor=jwein]
Target Milestone: --- → mozilla10
Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0

Verified the fix on the latest Firefox 10.0 beta 3 builds: non-ASCII characters are correctly displayed in video name in the statistics panel
Status: RESOLVED → VERIFIED
Keywords: verified-beta
Whiteboard: [good first bug][mentor=jwein] → [good first bug][mentor=jwein][qa!]
You need to log in before you can comment on or make changes to this bug.