694434 - Non-ASCII filename on statistics overlay shows as escaped unicode

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Alexander L. Slovesnik]

Attachment: Screenshot of the bug

STR:
1) Give video file Non-ASCII filename, for example: Basilique du Sacré-Cœur de Montmartre.ogg
2) Play this file in Firefox
3) Open statistics overlay during play

Expected results: Media field contains "Basilique du Sacré-Cœur de Montmartre.ogg"
Actual results: Media field contains "Basilique%20du%20Sacr%C3%A9-C%C5%93ur%20de%20Montmartre.ogg"

It looks really ugly.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

In /toolkit/content/widgets/videocontrols.xml, we will need to do some type of escaping when we set the textContent so that the text isn't mangled and still displays non-ASCII text correctly.

Comment 2

[Panu Horsmalahti]

Attachment: Patch to fix bug 694434.

Fixed using the decodeURI function in videocontrols.xml.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 569469 [details] [diff] [review]
Patch to fix bug 694434.

Untested, but it looks good to me. Forwarding to Justin for review.

Thanks for your first patch :)

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 569469 [details] [diff] [review]
Patch to fix bug 694434.

Review of attachment 569469 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, thanks for the patch!

Comment 5

[Panu Horsmalahti]

Jared, can you (or someone else) push the code into the tree?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Marking as checkin-needed in case someone else checks it in before I do.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/06e8e34e0abe

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/06e8e34e0abe

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0

Verified the fix on the latest Firefox 10.0 beta 3 builds: non-ASCII characters are correctly displayed in video name in the statistics panel