Closed Bug 694464 Opened 8 years ago Closed 8 years ago

c-c configure.in: port bug 464088 and bug 690369. (NSS_DISABLE_DBM)

Categories

(MailNews Core :: Build Config, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 11.0

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file)

Noticed while working on bug 690369.
Flags: in-testsuite-
Copy bug 464088 and
"
http://hg.mozilla.org/mozilla-central/rev/f0b46212962e
Fix indentation in configure --help. Whitespace changes only.
"

NB: c-c ignores "WebM".
Attachment #566996 - Flags: review?(kairo)
Attachment #566996 - Flags: review?(bugspam.Callek)
Attachment #566996 - Flags: review?(mbanner)
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

I don't care for this, it doesn't seem high value for us, we should spend the time on bug 648979.
Attachment #566996 - Flags: review?(mbanner)
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

Review of attachment 566996 [details] [diff] [review]:
-----------------------------------------------------------------

Man, I so much want to get rid of even needing to care about this, it's so useless. We're not using this in c-c anywhere and never will, it's just clutter.

The patch is correct for adding the --disable-dbm flag, but I'm not sure if we even should bother. Callek, what's your opinion?
Attachment #566996 - Flags: review?(kairo)
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

Wouldn't have bothered with this, but r+=me
Attachment #566996 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/4d583d242668
Attachment #566996 - Attachment description: (Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option → (Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option [Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 10.0 → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.