Last Comment Bug 694464 - c-c configure.in: port bug 464088 and bug 690369. (NSS_DISABLE_DBM)
: c-c configure.in: port bug 464088 and bug 690369. (NSS_DISABLE_DBM)
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 11.0
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 464088 690369
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-13 17:41 PDT by Serge Gautherie (:sgautherie)
Modified: 2011-12-01 16:18 PST (History)
0 users
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option [Checked in: Comment 5] (2.02 KB, patch)
2011-10-13 18:43 PDT, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-10-13 17:41:52 PDT
Noticed while working on bug 690369.
Comment 1 Serge Gautherie (:sgautherie) 2011-10-13 18:43:29 PDT
Created attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

Copy bug 464088 and
"
http://hg.mozilla.org/mozilla-central/rev/f0b46212962e
Fix indentation in configure --help. Whitespace changes only.
"

NB: c-c ignores "WebM".
Comment 2 Mark Banner (:standard8) 2011-11-07 02:43:37 PST
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

I don't care for this, it doesn't seem high value for us, we should spend the time on bug 648979.
Comment 3 Robert Kaiser 2011-11-26 17:14:27 PST
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

Review of attachment 566996 [details] [diff] [review]:
-----------------------------------------------------------------

Man, I so much want to get rid of even needing to care about this, it's so useless. We're not using this in c-c anywhere and never will, it's just clutter.

The patch is correct for adding the --disable-dbm flag, but I'm not sure if we even should bother. Callek, what's your opinion?
Comment 4 Justin Wood (:Callek) 2011-12-01 12:50:37 PST
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

Wouldn't have bothered with this, but r+=me
Comment 5 Serge Gautherie (:sgautherie) 2011-12-01 16:18:32 PST
Comment on attachment 566996 [details] [diff] [review]
(Av1) configure.in: add --disable-dbm (NSS_DISABLE_DBM) option
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/4d583d242668

Note You need to log in before you can comment on or make changes to this bug.