694572 - Move graph legends outside of graph area

Status: RESOLVED FIXED

(Testing Graveyard :: GoFaster, defect)

Description

[Chris AtLee [:catlee]]

They're currently in the upper-left corner of the graph, and end up obscuring a lot of data.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: patch

Move to the legend to the right of the graph.

Comment 2

[Jonathan Griffin (:jgriffin)]

Pushed as https://github.com/jonallengriffin/gofaster_dashboard/commit/d4b0d754c557312ad3e104640c8aaaf72686e28d

Comment 3

[William Lachance (:wlach)]

Comment on attachment 569462 [details] [diff] [review]
patch

Looks good, it seems a bit a shame that we have to duplicate "$('#legend').html(null);" all over the place, but a fix to that is probably beyond the scope of this bug.

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to William Lachance (:wlach) from comment #3)
> Comment on attachment 569462 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> Looks good, it seems a bit a shame that we have to duplicate
> "$('#legend').html(null);" all over the place, but a fix to that is probably
> beyond the scope of this bug.

Yeah it's a little gross, but fixing that would require digging a little deeper than I wanted to get for a cosmetic issue.

Deployed.