694643 - fetching of manifests in owa extension

Status: VERIFIED FIXED

(Web Apps :: Extension, defect, P1)

Description

[[e-mail] [:onecyrenus]]

This is the code, basically I worry that this isn't behind a timeout, and what is our strategy to catch exceptions when they happen at this level ? 

function fetchManifest(url, cb) {
  dump("APPS | api.install.fetchManifest | Fetching manifest from " + url + "\n");
  // contact our server to retrieve the URL
  let xhr = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].
  createInstance(Ci.nsIXMLHttpRequest);
  xhr.open("GET", url, true);
  xhr.onreadystatechange = function(aEvt) {
    if (xhr.readyState == 4) {
      if (xhr.status == 200) {
        dump("APPS | api.install.fetchManifest | Got manifest (200) " + xhr.responseText.length + " bytes\n");
        cb(xhr.responseText, xhr.getResponseHeader('Content-Type'));
      } else {
        dump("Failed to get manifest (" + xhr.status + ")\n");
        cb(null);
      }
    }
  };
  xhr.send(null);
}

Comment 1

[Shane Caraveo (:mixedpuppy)]

it might be a good idea to adopt some code from 

https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/webapps/

as it seems to be handling errors better.  Not sure if that would work in a timeline for alpha.

Comment 3

[Anant Narayanan [:anant]]

Attachment: More robust XHR handling

https://github.com/mozilla/openwebapps/pull/151

Comment 4

[Anant Narayanan [:anant]]

r+'ed on IRC: https://github.com/mozilla/openwebapps/commit/4686fe763ceb5ba20f96539d542abd8416d01fb7