Closed Bug 694644 Opened 8 years ago Closed 8 years ago

Reftest should turn off locale picker when running on mobile

Categories

(Testing :: Reftest, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: cmtalbert, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch the patch (obsolete) — Splinter Review
This is probably not causing us any issues, but we turn this off for mochitests, so it seems like we should turn it off for reftests too.

Note that even with this off, you don't get the reftests foregrounded in the UI.  What you get is the reftest window opening up and then the fennec UI opening up on top of it.  So you're looking at the fennec UI and it doesn't appear that anything is happening, but the reftests themselves are running in the window behind the fennec ui.

Attaching a patch to deal with the locale picker issue.
Attachment #567159 - Flags: review?(jmaher)
Comment on attachment 567159 [details] [diff] [review]
the patch

Review of attachment 567159 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/remotereftest.py
@@ +336,5 @@
>            fhandle = open(os.path.join(profileDir, "user.js"), 'a')
>            fhandle.write("""
>  user_pref("capability.principal.codebase.p2.granted", "UniversalPreferencesWrite UniversalXPConnect UniversalBrowserWrite UniversalPreferencesRead UniversalBrowserRead");
>  user_pref("capability.principal.codebase.p2.id", "http://%s:%s");
> +user_pref("browser.firstrun.show.localepicker", false);

can we move this out of the options.enablePrivilege block?  That will require us to do another fhandle open/write/close.
Attachment #567159 - Flags: review?(jmaher) → review-
Attached patch A better patchSplinter Review
Good point. I didn't realize I was inside that if statement.  Been coding too much javascript.

Here's a version that does the locale picker preference no matter what, and only adds the enable privilege stuff if we're running jsreftest.  It also only opens the file once.
Attachment #567159 - Attachment is obsolete: true
Attachment #567171 - Flags: review?(jmaher)
Comment on attachment 567171 [details] [diff] [review]
A better patch

Review of attachment 567171 [details] [diff] [review]:
-----------------------------------------------------------------

looks great, thanks!
Attachment #567171 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/5321159aac61
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.