694657 - Sync: test JS server 404 for GET on missing WBO

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

There was a case where a 404 for a WBO in a non-existent collection would return 200. Here's a patch.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 567179 [details] [diff] [review]
Proposed patch. v1

>       switch (req.method) {
>         case "GET":
>           if (!coll) {
>+            if (wboID) {
>+              respond(404, "Not found", "Not found");
>+              return;
>+            }
>             // *cries inside*: Bug 687299.
>             respond(200, "OK", "[]");

You and me, brother.


>+  function getMissingCollectionWBO(next) {
>+    _("Testing that fetching a WBO from an on-existent collection 404s.");
>+    let req = localRequest(storageURL + "/foobar/baz");
>+    req.get(function (err) {
>+      do_check_eq(this.response.status, 404);
>+      Utils.nextTick(next);
>+    });
>+  }
>+
>+  s.start(8080,

(sigh @ one letter variable name)

r=me

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/9c072e3fa138
https://hg.mozilla.org/services/services-central/rev/8c1ad90b6804

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/9c072e3fa138
https://hg.mozilla.org/mozilla-central/rev/8c1ad90b6804