Status
People
(Reporter: rnewman, Assigned: rnewman)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [fixed in services][qa-])
Attachments
(1 attachment)
|
2.43 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
There was a case where a 404 for a WBO in a non-existent collection would return 200. Here's a patch.
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 567179 [details] [diff] [review] Proposed patch. v1
|
||
Comment 2•7 years ago
|
||
Comment on attachment 567179 [details] [diff] [review] Proposed patch. v1 > switch (req.method) { > case "GET": > if (!coll) { >+ if (wboID) { >+ respond(404, "Not found", "Not found"); >+ return; >+ } > // *cries inside*: Bug 687299. > respond(200, "OK", "[]"); You and me, brother. >+ function getMissingCollectionWBO(next) { >+ _("Testing that fetching a WBO from an on-existent collection 404s."); >+ let req = localRequest(storageURL + "/foobar/baz"); >+ req.get(function (err) { >+ do_check_eq(this.response.status, 404); >+ Utils.nextTick(next); >+ }); >+ } >+ >+ s.start(8080, (sigh @ one letter variable name) r=me
Attachment #567179 -
Flags: review?(philipp) → review+
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/9c072e3fa138 https://hg.mozilla.org/services/services-central/rev/8c1ad90b6804
Whiteboard: [fixed in services][qa-]
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9c072e3fa138 https://hg.mozilla.org/mozilla-central/rev/8c1ad90b6804
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•