Closed Bug 694684 Opened 10 years ago Closed 10 years ago
[birch] Change camel case and @android IDs
The Android convention uses underscores as opposed to camel case. Also, we want to use local IDs (@+id vs @android:id) for our own elements to avoid polluting the android namespace (and prevent problems like Mark and I encountered with the favicon).
Attachment #567203 - Flags: review?(mark.finkle)
Assignee: nobody → bnicholson
OS: Linux → Android
Hardware: x86_64 → All
Attachment #567203 - Attachment is patch: true
Comment on attachment 567203 [details] [diff] [review] fixes ids Makes sense to follow the guidelines and avoid the namespace issues.
Attachment #567203 - Flags: review?(mark.finkle) → review+
Product: Fennec → Fennec Native
Version: Trunk → unspecified
Brian, your patch doesn't apply cleanly to trunk anymore. Could you upload an update version?
Attachment #569237 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.