Closed
Bug 694684
Opened 13 years ago
Closed 13 years ago
[birch] Change camel case and @android IDs
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file, 3 obsolete files)
|
15.32 KB,
patch
|
Details | Diff | Splinter Review |
The Android convention uses underscores as opposed to camel case. Also, we want to use local IDs (@+id vs @android:id) for our own elements to avoid polluting the android namespace (and prevent problems like Mark and I encountered with the favicon).
|
Assignee | |
Updated•13 years ago
|
Attachment #567203 -
Flags: review?(mark.finkle)
|
||
Updated•13 years ago
|
Assignee: nobody → bnicholson
OS: Linux → Android
Hardware: x86_64 → All
|
||
Updated•13 years ago
|
Attachment #567203 -
Attachment is patch: true
|
|
||
Comment 1•13 years ago
|
||
Comment on attachment 567203 [details] [diff] [review]
fixes ids
Makes sense to follow the guidelines and avoid the namespace issues.
Attachment #567203 -
Flags: review?(mark.finkle) → review+
|
||
Updated•13 years ago
|
Product: Fennec → Fennec Native
Version: Trunk → unspecified
|
||
Comment 2•13 years ago
|
||
Brian, your patch doesn't apply cleanly to trunk anymore. Could you upload an update version?
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #567203 -
Attachment is obsolete: true
Attachment #569229 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #569229 -
Attachment is obsolete: true
Attachment #569229 -
Flags: review?(mark.finkle)
Attachment #569237 -
Flags: review?(mark.finkle)
|
|
||
Updated•13 years ago
|
Attachment #569237 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #569237 -
Attachment is obsolete: true
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•