Closed Bug 694684 Opened 8 years ago Closed 8 years ago

[birch] Change camel case and @android IDs

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

Details

Attachments

(1 file, 3 obsolete files)

Attached patch fixes ids (obsolete) — Splinter Review
The Android convention uses underscores as opposed to camel case.  Also, we want to use local IDs (@+id vs @android:id) for our own elements to avoid polluting the android namespace (and prevent problems like Mark and I encountered with the favicon).
Attachment #567203 - Flags: review?(mark.finkle)
Assignee: nobody → bnicholson
OS: Linux → Android
Hardware: x86_64 → All
Attachment #567203 - Attachment is patch: true
Comment on attachment 567203 [details] [diff] [review]
fixes ids

Makes sense to follow the guidelines and avoid the namespace issues.
Attachment #567203 - Flags: review?(mark.finkle) → review+
Product: Fennec → Fennec Native
Version: Trunk → unspecified
Brian, your patch doesn't apply cleanly to trunk anymore. Could you upload an update version?
Attached patch rebased patch (obsolete) — Splinter Review
Attachment #567203 - Attachment is obsolete: true
Attachment #569229 - Flags: review?(mark.finkle)
Attached patch rebased again (obsolete) — Splinter Review
Attachment #569229 - Attachment is obsolete: true
Attachment #569229 - Flags: review?(mark.finkle)
Attachment #569237 - Flags: review?(mark.finkle)
Attachment #569237 - Flags: review?(mark.finkle) → review+
Attachment #569237 - Attachment is obsolete: true
https://hg.mozilla.org/projects/birch/rev/3189ade55817
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.