694796 - add localizers to humans.txt

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Luke Crouch [:groovecoder]]

for the localizers, discovered this trick:

svn log --quiet http://svn.mozilla.org/projects/mdn/trunk/locale/ | grep '^r' | awk '{print $3}' | sort | uniq > committers.txt

Comment 1

[David Bruant]

Add MDN contributors too?

Comment 2

[beimaginativeegroup]

Hi, I'm a new contributor and I'm interested in fixing this bug. Can anyone send me more information on how to begin, please?

Comment 3

[Buddy Lindsey]

(In reply to beimaginativeegroup from comment #2)
> Hi, I'm a new contributor and I'm interested in fixing this bug. Can anyone
> send me more information on how to begin, please?

If you look in comment 1 Luke has a command for getting the localization contributors out of svn via command line. Need to take that and incorporate that into the humans app in kuma. Preferably merge with getting data from github, but that needs to be fixed as well. Github updated their api, so it needs a tweak as well.

Comment 4

[beimaginativeegroup]

Oh sorry then. It seems too complicated.

Comment 5

[beimaginativeegroup]

I have decided to re-look at this bug and have begun working on it.

Comment 6

[beimaginativeegroup]

It's free again.

Comment 7

[meghashyam]

may I continue with it

Comment 8

[Luke Crouch [:groovecoder]]

Of course. You should be able to go thru https://github.com/mozilla/kuma/blob/mdn/README-vagrant.md to get a local instance of MDN so you can work on it.

Comment 9

[Armando Neto [:netoarmando]]

Attachment: Generated humans.txt file

Comment 10

[Armando Neto [:netoarmando]]

My pull request: https://github.com/mozilla/kuma/pull/891

I'm using subprocess to run the line mentioned in comment 1 by Luke. Not sure if secure enough.

I changed the format of humans.txt as well, as you can see in attachment 717680 [details] that I've just generated using my code suggestion.

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/bcd718054c8d9cf03b1dbdc03058a57dafee1562
Bug 694796 - add localizers to humans.txt

https://github.com/mozilla/kuma/commit/b0d060e900c4122b8395e3b31f25602aa6c75ff5
Bug 694796 now respecting PEP 8

https://github.com/mozilla/kuma/commit/e972fd992ee498f3cab043c4ea566360e2791298
test case fixed to work with bug 694796 patch

https://github.com/mozilla/kuma/commit/d7735c19ebf2b975f513b2c033d47447b415305b
Merge pull request #891 from netoarmando/bug-694796-localizers-humans_txt

Bug 694796 - add localizers to humans.txt

Comment 12

[Luke Crouch [:groovecoder]]

Merged. https://github.com/mozilla/kuma/commit/d7735c19ebf2b975f513b2c033d47447b415305b

Comment 13

[Luke Crouch [:groovecoder]]

Will take a while to show up on prod since the cron only runs every few hours I think.