694802 - VC11 cannot compile nsWindow.cpp because it #includes <pbt.h>

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(no longer active)]

This header was added in bug 464091.  We no longer support Windows CE, and on other versions of Windows, #including windows.h is enough.  The SDK headers shipping with VC11 no longer include this file.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Brian R. Bondy [:bbondy]]

Are you using Windows SDK 8.0 by the way or 7.0|7.1?

Comment 3

[Brian R. Bondy [:bbondy]]

I assume you ar eusing Windows SDK 8 because the file is already included in 7.0 and 7.1.

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 567313 [details] [diff] [review]
Patch (v1)

Review of attachment 567313 [details] [diff] [review]:
-----------------------------------------------------------------

- Verified that I get the problem building with VC2011 on Win7 and Windows SDK v7.1 and that the patch fixes it.
- Verified that it doesn't cause a problem with VS2010 w/ 7.1
- Did not try other supported setups but I think it will be OK.

Comment 5

[(no longer active)]

(In reply to Brian R. Bondy [:bbondy] from comment #2)
> Are you using Windows SDK 8.0 by the way or 7.0|7.1?

Sorry for the late reply.  I'm getting the problem with the SDK version shipping with VC2011 (I believe they call it 8.0).

Comment 6

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/34bf415c96bb

Comment 7

[Brian R. Bondy [:bbondy]]

You can tell by the way when you run start-msvc11.bat it will output something like:
Windows SDK version: 7.1

Comment 8

[Brian R. Bondy [:bbondy]]

Also just out of curiosity are you using a 64bit machine?

If so does the developer preview put anything inside your Program files directory? Or only Program Files (x86)?

For me:
C:\Program Files\Microsoft SDKs\Windows 
has v7.0 and v7.1 folders

But:
C:\Program Files (x86)\Microsoft SDKs\Windows has
has v7.0A, v8.0 and v8.0A folders

Comment 9

[(no longer active)]

(In reply to Brian R. Bondy [:bbondy] from comment #8)
> Also just out of curiosity are you using a 64bit machine?

Yep, a 64-bit VM.

> If so does the developer preview put anything inside your Program files
> directory? Or only Program Files (x86)?
> 
> For me:
> C:\Program Files\Microsoft SDKs\Windows 
> has v7.0 and v7.1 folders
> 
> But:
> C:\Program Files (x86)\Microsoft SDKs\Windows has
> has v7.0A, v8.0 and v8.0A folders

As far as I can tell, everything goes under Program Files (x86).

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/34bf415c96bb