694803 - Save event with Ctrl-S after changing calendar produces misleading dialogues

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Harold]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111011182523

Steps to reproduce:

Edit an event and assign the event to an alternate calendar. 
Save the edited event by using Ctrl-S.
Exit out of the edit screen by pressing <esc>


Actual results:

A dialogue box appears asking if you wish to save or not save.
If you press "Save" an information box appears: "An error occurred when writing to the calendar "calendar-name". Details: Error code: "MODIFICATION_FAILED"



Expected results:

The change was accurately saved with Crtl-S; it makes no difference if you press "Save" or "Don't Save" in the dialogue box - the change is saved anyway.
The dialogue box should not appear.
The information box indicating an error should not appear.

Comment 1

[Harold]

Lightning 1.0rc1; TB 8.0; Windows 7.

Comment 2

[Matthew Mecca [:mmecca]]

Confirming.

Comment 3

[Matthew Mecca [:mmecca]]

Attachment: Fix v1

When the calendar of the item is changed, onOperationComplete gets called twice on the listener, once when the new item is added to the new calendar and again when the old item is removed from the original calendar. This patch checks to make sure we're receiving the update on the right calendar before updating the window's item.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 591346 [details] [diff] [review]
Fix v1

Review of attachment 591346 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe you could add a comment there to make sure this is still taken into account when the code is changed.

Comment 5

[Matthew Mecca [:mmecca]]

Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/145f94bea560