Closed
Bug 694890
Opened 13 years ago
Closed 13 years ago
Subject and date labels don't line up
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: squib, Assigned: squib)
Details
Attachments
(2 files)
20.07 KB,
image/png
|
Details | |
1.24 KB,
patch
|
bwinton
:
review+
|
Details | Diff | Splinter Review |
The subject and date labels in the message header don't have the same Y position. Let's fix this. While we're here, we should probably straighten up the CSS a bit, since it's pretty messy. For instance, do we really want line-height: 1.5em on the rows? Note that the screenshot shows Linux, but this applies to Windows (XP and 7) as well. I wouldn't be surprised if Mac were also affected, but I don't have a Mac to test this on.
Assignee | ||
Comment 1•13 years ago
|
||
(In reply to Jim Porter (:squib) from comment #0) > While we're here, we should probably straighten up the CSS a bit, since it's > pretty messy. For instance, do we really want line-height: 1.5em on the rows? Actually, I suppose we could do this in another bug, though we'd do well to at least think about it now.
Comment 2•13 years ago
|
||
I'm hoping this will fall out of putting the header buttons into a new toolbar of their own, but if you want to fix it, I wouldn't object too strongly. :) Oh, and they do line up on Mac: http://dl.dropbox.com/u/2301433/Screenshots/SubjectAndDateLine.png Thanks, Blake.
Assignee | ||
Comment 3•13 years ago
|
||
This is pretty simple. I just copied the relevant bits of the .headerValue class to .dateLabel. I also made sure the end of the date label is vertically aligned with the text on the delete button, at least in the default themes.
Attachment #567646 -
Flags: review?(bwinton)
Comment 4•13 years ago
|
||
Comment on attachment 567646 [details] [diff] [review] Fix this on Windows and Linux Review of attachment 567646 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #567646 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/515e751fd708
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in
before you can comment on or make changes to this bug.
Description
•