Last Comment Bug 694941 - add image feature for contributor forums
: add image feature for contributor forums
Status: RESOLVED FIXED
u=contributor c=forums p=1 s=2013.4
:
Product: support.mozilla.org
Classification: Other
Component: Forum (show other bugs)
: unspecified
: All All
: P3 normal with 1 vote (vote)
: 2013Q1
Assigned To: Ricky Rosario [:rrosario, :r1cky]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-17 03:42 PDT by Kadir Topal [:atopal]
Modified: 2013-03-04 07:52 PST (History)
10 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Kadir Topal [:atopal] 2011-10-17 03:42:46 PDT
Currently it's not possible to attach images to contributor forum postings. Since that is an often requested feature, please add that ability to forums.
Comment 1 Ricky Rosario [:rrosario, :r1cky] 2012-02-02 11:23:32 PST
Cleaning up 2011Q4
Comment 2 Rosana Ardila 2012-08-07 08:28:07 PDT
I think this should be implemented.

User story:
I, as a SUMO forum user, would like to include images on my posts. This should be as easy for me as adding links in the forum.
Comment 3 madalina 2012-08-08 06:02:00 PDT
Endorsing this as it's an important feature of the discussion forums which contributors often ask for.
Comment 4 Will Kahn-Greene [:willkg] 2012-08-14 09:49:25 PDT
To clarify some bits here:

1. add image uploading to the contributor forums just like we currently have in the support forums
2. no special permission is required to upload an image---anyone can do it
3. no anti-spam prevention measures will be implemented
4. no image management will be implemented (i.e. someone uploads a bad image and we want to remove it from the site)

I haven't touched the support forum code, so I don't know what this entails. I'd have to read through the code before giving an estimate that's not a wild guess. I suspect Ricky knows more.
Comment 5 Ricky Rosario [:rrosario, :r1cky] 2012-08-14 12:17:11 PDT
I think this is about being able to add images in the same way they are added to KB articles. There would be an image button/icon in the editor toolbar that allows you to select an image from the media gallery. All image uploads would happen through the existing gallery app.

Kadir, is this correct?
Comment 6 Kadir Topal [:atopal] 2012-08-15 01:54:48 PDT
Ricky, this is rather like the support forum upload. We don't want these images in the media gallery. They might be screenshots to illustrate an issue, or random images. There is no intention to reuse the images in other places.
Comment 7 Ricky Rosario [:rrosario, :r1cky] 2012-08-21 07:56:07 PDT
(In reply to Kadir Topal [:atopal] from comment #6)
> Ricky, this is rather like the support forum upload.

If we can't use the existing media gallery, the complexity of this shoots up to be a multiple bug project. We'll need definition of new workflows for uploading and figure out how we can integrate that into our existing wiki markup (I am not even sure how this can be done, the parser ties [[Image...]] to the media gallery pretty tightly.
Comment 8 Rosana Ardila 2012-08-21 08:15:27 PDT
I don't see a problem with having the images in the gallery, if we can offer this feature quickly. Maybe it is easier to organize the gallery better?
But I would go for a simpler solution at the beginning, as Ricky suggested.
Comment 9 Verdi [:verdi] 2012-08-21 11:45:55 PDT
I think I wouldn't mind extra images in the media gallery. It's rare that I can reuse images and when I do, searching for them works. I don't manually page though images. The image I want is almost always on the front page or it's old and I have to search for it.

That said, what about creating a "locale" for these? That's kind of hacky but if it doesn't require much work maybe it would be best to put contributor forum uploads in a "contributor" locale. It might also prevent me from deleting some as spam on accident.
Comment 10 Ricky Rosario [:rrosario, :r1cky] 2012-08-22 07:53:14 PDT
(In reply to Verdi from comment #9)
> That said, what about creating a "locale" for these? That's kind of hacky
> but if it doesn't require much work maybe it would be best to put
> contributor forum uploads in a "contributor" locale. It might also prevent
> me from deleting some as spam on accident.

I don't think this is possible the way we have implemented it. I'll take a look and see if there is any easy way we could identify them.
Comment 11 Ricky Rosario [:rrosario, :r1cky] 2012-08-27 13:13:06 PDT
I think the long term solution is to add metadata to media files to make it easier to find what you need and filter out what you don't.
Comment 12 Scoobidiver (away) 2012-09-24 15:22:29 PDT
It should be re-targeted.
Comment 13 Rosana Ardila 2013-01-15 04:01:55 PST
Our contributors are also asking for this feature on the forums. We hope you can get to this soon!
Comment 14 Kadir Topal [:atopal] 2013-01-15 07:00:00 PST
We'll try to get to it this quarter. Ricky, let's use the media gallery and let's add the meta data so this is not all dumped into The One gallery we show to kb editors. Even if we don't want to create the front end for it now we should be able to filter forum images out later.

Putting into next sprint, so we can estimate and potentially get this implemented.
Comment 15 Ricky Rosario [:rrosario, :r1cky] 2013-01-15 07:02:31 PST
So can we clarify what we are doing and the workflow? Do we want images inline in a post like in articles or do we just want images attached to a post like in the support forum?
Comment 16 Kadir Topal [:atopal] 2013-01-15 07:07:57 PST
We'd have them inline, like in articles and we'd also use the same infrastructure, namely the media gallery.
Comment 17 Ricky Rosario [:rrosario, :r1cky] 2013-01-15 09:35:18 PST
There are several options here.

1- Use media gallery and possibly add metadata to the images. We still might need to tweak the wiki parser settings used in the contributor forum because they are different from the kb parser.
2- Create a new upload path and insert HTML instead of wiki [Image...] syntax.
3- ?
4- Profit

Either way, it isn't trivial => 3pt
Comment 18 Alice Wyman 2013-01-15 10:12:25 PST
So, if the media gallery is going to be used for contributor forum images, who will delete inappropriate images that might get posted?  Moderators can currently delete images from the support forum but not from the media gallery.  

Related discussion: 
*https://support.mozilla.org/forums/contributors/708819 Gallery content should require approval
Comment 19 Alice Wyman 2013-01-15 10:24:41 PST
 (In reply to Alice Wyman from comment #18)
> So, if the media gallery is going to be used for contributor forum images,
> who will delete inappropriate images that might get posted?  Moderators can
> currently delete images from the support forum but not from the media
> gallery.  

To answer my own question:  
A link to the inappropriate media gallery image can be referred to an admin for review and possible deletion, just like we do now in the Media Gallery thread, https://support.mozilla.org/forums/contributors/708051 ... and then a moderator can edit out the image from the contributor forum post or delete the post.
Comment 20 Kadir Topal [:atopal] 2013-02-05 10:51:55 PST
Falling to next sprint.
Comment 21 Ricky Rosario [:rrosario, :r1cky] 2013-02-26 09:17:30 PST
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #17)
> 1- Use media gallery and possibly add metadata to the images. We still might
> need to tweak the wiki parser settings used in the contributor forum because
> they are different from the kb parser.

Let's start by trying this option.
Comment 22 Ricky Rosario [:rrosario, :r1cky] 2013-03-01 08:29:56 PST
In a pull request:
https://github.com/mozilla/kitsune/pull/1175

I am revising this down to 1pt because it turns out we were just missing the UI for it. When estimating at 3pts, I thought we were going to have to modify the parser used in the forums to support [[Image:...]] like the kb/wiki parser. Turns out that our base parser already supports Images (not Videos or Templates or Includes, though). That made this so much easieer.
Comment 23 Ricky Rosario [:rrosario, :r1cky] 2013-03-01 12:49:50 PST
Landed on master:
https://github.com/mozilla/kitsune/commit/f483dd56880a3bb490f2599db1686248b2e626f2
Comment 24 Ricky Rosario [:rrosario, :r1cky] 2013-03-04 07:52:17 PST
Deployed to prod now.

Note You need to log in before you can comment on or make changes to this bug.