Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Created attachment 567571 [details] [diff] [review] Patch 1.0 - Decouple the driver from the test harness In this definition, the driver is controller.js, elementslib.js, mozelement.js, mozmill.js and init.js. The test harness is basically frame.js. This patch re-factors mozmill such that none of the driver files reference any of the test harness files. This allows the driver files to be isolated and used in other applications such as peptest. It is done using the observer design pattern. This patch only addresses the first step in the above comment. Once this is approved and committed we can maybe move directories around, but I'd rather do it incrementally.
Created attachment 567573 [details] [diff] [review] Patch 1.1 - Decouple driver from test harness Forgot to add a file to the diff, see comment on previous patch.
Attachment #567573 - Flags: review?(jhammel)
I'll have to look at the patch closer to see what to do with it. On first glance, though, it seems like frame.MozmillMessageListener is an unnecessary abstraction.
Comment on attachment 567573 [details] [diff] [review] Patch 1.1 - Decouple driver from test harness After talking to :ahal, a few things: - listener.update() should just be listener() - listeners are keyed by event type; we could have global listeners but do not yet - MozmillMsgListener is an unnecessary abstraction; just move this code into events
Attachment #567573 - Flags: review?(jhammel) → review-
Created attachment 567885 [details] [diff] [review] counter-proposal
Comment on attachment 567885 [details] [diff] [review] counter-proposal Review of attachment 567885 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, I like this a lot better than the original. So once this gets checked in I can throw together a patch that re-factors the directory structure. If I remember correctly, it was mostly just changing import statements.
Attachment #567885 - Flags: review?(ahalberstadt) → review+
pushed to master: https://github.com/mozautomation/mozmill/commit/1c4d1e6f5599e3c54e71c7c1875973a947e801c2 Follow up issues should be separately filed
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.