695092 - Unable to upload an app which has default locale set to a non en-us locale

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/developers/apps/submit/1
2. Upload an app which has default app set to a non en-US locale- https://people.mozilla.com/~kraj/test-files/webapps/webapp-with-it-as-default-locale.webapp
3. Notice the fields in step 3.


actual behavior:
Step 3 of upload loads with app name missing and user is not able to proceed with the upload.

Uploading in "it" locale works fine. We should allow users to upload apps in a locale which is different from the default locale of the app.

Comment 1

[Jeff Balogh (:jbalogh)]

The default_locale is correct but the string is created with the wrong locale.

mysql> select name,defaultlocale from addons where id=337504;
+---------+---------------+
| name    | defaultlocale |
+---------+---------------+
| 2492988 | it            |
+---------+---------------+
1 row in set (0.00 sec)

mysql> select id,locale,localized_string from translations where id=2492988;
+---------+--------+------------------+
| id      | locale | localized_string |
+---------+--------+------------------+
| 2492988 | en-us  | MozillaBall2     |
+---------+--------+------------------+
1 row in set (0.01 sec)

Comment 2

[Wil Clouser [:clouserw]]

Doesn't block the store, but it might come up.

Comment 3

[Kumar McMillan [:kumar]]

Fixed: https://github.com/mozilla/zamboni/commit/2d3436a

Comment 4

[Kumar McMillan [:kumar]]

Better fix! https://github.com/mozilla/zamboni/commit/38ae137