Closed Bug 695100 Opened 8 years ago Closed 8 years ago

[birch] Code cleanup

Categories

(Firefox for Android :: General, defect, P4)

All
Android
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(8 files, 7 obsolete files)

6.32 KB, patch
lucasr
: review+
Details | Diff | Splinter Review
4.77 KB, patch
Details | Diff | Splinter Review
11.51 KB, patch
lucasr
: review+
Details | Diff | Splinter Review
965 bytes, patch
lucasr
: review+
Details | Diff | Splinter Review
14.99 KB, patch
Details | Diff | Splinter Review
4.81 KB, patch
lucasr
: review+
Details | Diff | Splinter Review
2.16 KB, patch
lucasr
: review+
Details | Diff | Splinter Review
22.52 KB, patch
kats
: review+
Details | Diff | Splinter Review
The birch code is generally very messy with respect to coding standards and java code conventions. Time to fix it up.
Attached patch Clean up AwesomeBar.java (obsolete) — Splinter Review
Attachment #567534 - Flags: review?(lucasr.at.mozilla)
Assignee: kgupta → nobody
OS: Mac OS X → Android
Product: Fennec → Fennec Native
Hardware: x86 → All
Version: Trunk → unspecified
Attachment #567526 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #567534 - Attachment is obsolete: true
Attachment #567534 - Flags: review?(lucasr.at.mozilla)
Attachment #567536 - Flags: review?(lucasr.at.mozilla)
Not java code, but counts as code cleanup in fennec-native nonetheless :)
Attachment #567539 - Flags: review?(lucasr.at.mozilla)
Assignee: nobody → kgupta
Comment on attachment 567536 [details] [diff] [review]
Clean up AwesomeBar.java

Review of attachment 567536 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #567536 - Flags: review?(lucasr.at.mozilla) → review+
Comment on attachment 567539 [details] [diff] [review]
Fix a build warning

Review of attachment 567539 [details] [diff] [review]:
-----------------------------------------------------------------

How is this fixing a build warning? A little more context would help here.
(In reply to Lucas Rocha (:lucasr) from comment #7)
> How is this fixing a build warning? A little more context would help here.

While building, this shows up in the build output:

Makefile:213: target `res/layout/gecko_menu.xml' given more than once in the same rule.

The file is listed twice in the same block (you can see the other occurrence at the top of the diff context).
Attached patch Clean up CrashReporter.java.in (obsolete) — Splinter Review
Will upload a ignore-whitespace diff as well.
Attachment #567556 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 567539 [details] [diff] [review]
Fix a build warning

Review of attachment 567539 [details] [diff] [review]:
-----------------------------------------------------------------

How is this fixing a build warning? A little more context would help here.
Attachment #567539 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #567556 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #567569 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #567589 - Flags: review?(lucasr.at.mozilla) → review+
I backed out http://hg.mozilla.org/projects/birch/rev/b559e3ee4ce9 that broke the build:
https://hg.mozilla.org/projects/birch/rev/b35d89b7a705
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I missed the build problem somehow before pushing. Here's an updated version.
Attachment #567556 - Attachment is obsolete: true
Attachment #567724 - Flags: review?(kgupta)
Comment on attachment 567724 [details] [diff] [review]
Clean up CrashReporter.java.in (Fixed version)

My mistake on the bad patch; I had --disable-crashreporter set in my mozconfig (required on Mac) so this file never actually got compiled. Your fixes look good.
Attachment #567724 - Flags: review?(kgupta) → review+
Pushed: http://hg.mozilla.org/projects/birch/rev/071451d7ff51
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Have more patches coming up for this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Clean up GeckoEvent.java (obsolete) — Splinter Review
Attachment #567778 - Flags: review?(lucasr.at.mozilla)
Attached patch Fix error in bookmarks (obsolete) — Splinter Review
Attachment #567779 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 567779 [details] [diff] [review]
Fix error in bookmarks

Patch moved to bug 695595
Attachment #567779 - Attachment is obsolete: true
Attachment #567779 - Flags: review?(lucasr.at.mozilla)
Attached patch Clean up App.java.in (obsolete) — Splinter Review
Attachment #569400 - Flags: review?(lucasr.at.mozilla)
Attached patch Clean up GeckoEvent.java (v2) (obsolete) — Splinter Review
Rebased to latest birch
Attachment #567778 - Attachment is obsolete: true
Attachment #567778 - Flags: review?(lucasr.at.mozilla)
Attachment #569401 - Flags: review?(lucasr.at.mozilla)
Attached patch Clean up SurfaceInfo.java (obsolete) — Splinter Review
Attachment #569415 - Flags: review?(lucasr.at.mozilla)
Priority: -- → P4
Attachment #569400 - Attachment is obsolete: true
Attachment #569400 - Flags: review?(lucasr.at.mozilla)
Attachment #569401 - Attachment is obsolete: true
Attachment #569401 - Flags: review?(lucasr.at.mozilla)
Attachment #569415 - Attachment is obsolete: true
Attachment #569415 - Flags: review?(lucasr.at.mozilla)
Closing this out; any additional cleanup items can be done as separate bugs.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.