Closed
Bug 695112
Opened 11 years ago
Closed 11 years ago
Fennec native menu items inaccessible on Honeycomb
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(3 files)
On the Galaxy Tab 10.1 (and presumably any other device running Android API >= 11) the menu items are inaccessible. This happens because the menu items are added to the "Action Bar", which is part of the title bar, which is turned off in the fennec-native app theming. Patch to fix this attached, which specifies a different theme style for API >= 11. The condition might need to be expanded to take device dimensions into account so small-screen phones running API >= 11 don't have the title bar, but for now this allows people with tablets to access the bookmarks/tabs screens.
Attachment #567543 -
Flags: review?(mark.finkle)
Comment 1•11 years ago
|
||
Comment on attachment 567543 [details] [diff] [review] Make menu items usable on Honeycomb We should be able to set the theme using special folder names, right? This is fine for now, but I'd like to avoid doing too much in code. Got a screenshot of this in action?
Attachment #567543 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
> We should be able to set the theme using special folder names, right? > If this is possible, then yes, it would be preferable. I didn't find how to do this in my admittedly cursory search. > This is fine for now, but I'd like to avoid doing too much in code. Got a > screenshot of this in action? Attached before and after screenshots. In the before pic, there is no way to get at the menu items.
Comment 5•11 years ago
|
||
Screenshots look good enough to land. I wonder what we need to do to add our own content/widgets to the actionbar.
Assignee | ||
Comment 6•11 years ago
|
||
In theory we can add stuff into the action bar according to http://developer.android.com/guide/topics/ui/actionbar.html - I'm not sure if we want to explore that further now or wait until we're more focused on tablets later.
Comment 7•11 years ago
|
||
(In reply to Kartikaya Gupta (:kats) from comment #6) > In theory we can add stuff into the action bar according to > http://developer.android.com/guide/topics/ui/actionbar.html - I'm not sure > if we want to explore that further now or wait until we're more focused on > tablets later. Wait for now, but the info is good to know.
Comment 8•11 years ago
|
||
http://hg.mozilla.org/projects/birch/rev/e6bfd145e323
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Ideally the URL bar should be in action bar as well, if we are targeting native UI for tablets too.
Comment 10•11 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #9) > Ideally the URL bar should be in action bar as well, if we are targeting > native UI for tablets too. Right, but that is not a goal for now. We will do that later.
Comment 11•10 years ago
|
||
Verified fixed on Fennec Nightly 13.0a1 (2012-02-08) Device: Samsung Galaxy Tab
Status: RESOLVED → VERIFIED
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•