695112 - Fennec native menu items inaccessible on Honeycomb

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Make menu items usable on Honeycomb

On the Galaxy Tab 10.1 (and presumably any other device running Android API >= 11) the menu items are inaccessible. This happens because the menu items are added to the "Action Bar", which is part of the title bar, which is turned off in the fennec-native app theming. Patch to fix this attached, which specifies a different theme style for API >= 11.

The condition might need to be expanded to take device dimensions into account so small-screen phones running API >= 11 don't have the title bar, but for now this allows people with tablets to access the bookmarks/tabs screens.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 567543 [details] [diff] [review]
Make menu items usable on Honeycomb

We should be able to set the theme using special folder names, right?

This is fine for now, but I'd like to avoid doing too much in code. Got a screenshot of this in action?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: UI on Galaxy Tab with patch applied

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: UI on Galaxy Tab without patch

Comment 4

[Kartikaya Gupta (email:[e-mail])]

> We should be able to set the theme using special folder names, right?
> 

If this is possible, then yes, it would be preferable. I didn't find how to do this in my admittedly cursory search.

> This is fine for now, but I'd like to avoid doing too much in code. Got a
> screenshot of this in action?

Attached before and after screenshots. In the before pic, there is no way to get at the menu items.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Screenshots look good enough to land.

I wonder what we need to do to add our own content/widgets to the actionbar.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

In theory we can add stuff into the action bar according to http://developer.android.com/guide/topics/ui/actionbar.html - I'm not sure if we want to explore that further now or wait until we're more focused on tablets later.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kartikaya Gupta (:kats) from comment #6)
> In theory we can add stuff into the action bar according to
> http://developer.android.com/guide/topics/ui/actionbar.html - I'm not sure
> if we want to explore that further now or wait until we're more focused on
> tablets later.

Wait for now, but the info is good to know.

Comment 8

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/projects/birch/rev/e6bfd145e323

Comment 9

[Sriram Ramasubramanian [:sriram]]

Ideally the URL bar should be in action bar as well, if we are targeting native UI for tablets too.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #9)
> Ideally the URL bar should be in action bar as well, if we are targeting
> native UI for tablets too.

Right, but that is not a goal for now. We will do that later.

Comment 11

[Catalin Suciu [:csuciu]]

Verified fixed on Fennec Nightly 13.0a1 (2012-02-08)
Device: Samsung Galaxy Tab