Closed Bug 695322 Opened 12 years ago Closed 12 years ago

browser_privatebrowsing_searchbar.js is broken when run on its own, and doesn't fully clean up after itself

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 10

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

patch
2.37 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
Two issues I discovered while debugging test failures in bug 692130:

1) this test leaves text in the search bar after it is run
2) this test fails when run individually

1) is easy to fix. 2) seems to be caused by assuming that the search bar already has an undo history, which isn't necessarily true given what the test does.
Attached patch patch — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #567741 -
        Flags: review?(ehsan)

    
  

        Attachment #567741 -
        Flags: review?(ehsan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5404bcfc627f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.