695356 - Daily graphics for installer could need some color for the background.

Status: RESOLVED FIXED

Description

[Andreas Nilsson (:andreasn)]

Looking at the installer again, it looks slightly odd with a white background for the "sidebar" image. It needs a background color. Patch coming up!

Comment 1

[Andreas Nilsson (:andreasn)]

Created attachment 568544 [details] [diff] [review]
graphics fix for daily and earlybird

Is there a good way to actually test this graphics in the installer?

Comment 2

[Jim Porter (:squib)]

Sorry, it looks like I lied on IRC. It appears that the try server will build installers for you, not just .zips.

Comment 3

[Andreas Nilsson (:andreasn)]

No problem, I could have double checked myself (as I actually built a tryserver build earlier the same day, but focused on the mac build only...). :)
Ok, tryserver it is!

Comment 4

[Wayne Mery (:wsmwk)]

I can't visualize exactly what this fix does, but apparently on windows with some theme or color settings it's hard to see the icon when doing alt+tab or finding Daily in the windows task bar.  (not my personal experience, but I've seen someone else mention it)

Comment 5

[Josiah Bruner [:jsbruner] [:📧🔒]]

(In reply to Wayne Mery (:wsmwk) from comment #4)
> I can't visualize exactly what this fix does, but apparently on windows with
> some theme or color settings it's hard to see the icon when doing alt+tab or
> finding Daily in the windows task bar.  (not my personal experience, but
> I've seen someone else mention it)

This is changing the look of the Thunderbird Installer, not anything related the app icon. If someone is using a white windows theme, it may indeed be hard to find Daily (since it's all white), but that would be a separate bug (and one without a real solution).

Comment 6

[Wayne Mery (:wsmwk)]

Easy to do?  Or no longer valid?

Comment 7

[Richard Marti (:Paenglab)]

Created attachment 9006064 [details] [diff] [review]
bug695356-installergfx.patch

Removed the no more existing aurora graphic.

It makes sense to use this graphic from Andreas because everywhere we use a orange background with the Daily egg.

Comment 8

[Jorg K (GMT+2)]

Comment on attachment 9006064 [details] [diff] [review]
bug695356-installergfx.patch

(In reply to Richard Marti (:Paenglab) from comment #7)
> Removed the no more existing aurora graphic.
What, where?

As far as I can see, the patch changes wizWatermark.bmp for Daily.

Comment 9

[Richard Marti (:Paenglab)]

Correct.

Comment 10

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #8)
> (In reply to Richard Marti (:Paenglab) from comment #7)
> > Removed the no more existing aurora graphic.
> What, where?

In Andreas's patch is still the aurora graphic. We have only the Nightly and Thunderbird branding. Aurora is gone.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4e3c8a149987
Change the background color of the Daily installer graphic to orange. r=jorgk