Closed Bug 695356 Opened 10 years ago Closed 3 years ago

Daily graphics for installer could need some color for the background.

Categories

(Thunderbird :: Installer, defect)

Product:
Thunderbird
Component:
Installer
Version:
10 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 63.0

People

(Reporter: andreasn, Assigned: Paenglab)

Details

Attachments

(2 files)

graphics fix for daily and earlybird
172.97 KB, patch
Details | Diff | Splinter Review
bug695356-installergfx.patch
59.85 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
Looking at the installer again, it looks slightly odd with a white background for the "sidebar" image. It needs a background color. Patch coming up!
Is there a good way to actually test this graphics in the installer?
Sorry, it looks like I lied on IRC. It appears that the try server will build installers for you, not just .zips.
No problem, I could have double checked myself (as I actually built a tryserver build earlier the same day, but focused on the mac build only...). :)
Ok, tryserver it is!
I can't visualize exactly what this fix does, but apparently on windows with some theme or color settings it's hard to see the icon when doing alt+tab or finding Daily in the windows task bar.  (not my personal experience, but I've seen someone else mention it)
(In reply to Wayne Mery (:wsmwk) from comment #4)
> I can't visualize exactly what this fix does, but apparently on windows with
> some theme or color settings it's hard to see the icon when doing alt+tab or
> finding Daily in the windows task bar.  (not my personal experience, but
> I've seen someone else mention it)

This is changing the look of the Thunderbird Installer, not anything related the app icon. If someone is using a white windows theme, it may indeed be hard to find Daily (since it's all white), but that would be a separate bug (and one without a real solution).
Easy to do?  Or no longer valid?
Flags: needinfo?(richard.marti)
Removed the no more existing aurora graphic.

It makes sense to use this graphic from Andreas because everywhere we use a orange background with the Daily egg.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9006064 - Flags: review?(jorgk)
Comment on attachment 9006064 [details] [diff] [review]
bug695356-installergfx.patch

(In reply to Richard Marti (:Paenglab) from comment #7)
> Removed the no more existing aurora graphic.
What, where?

As far as I can see, the patch changes wizWatermark.bmp for Daily.
Attachment #9006064 - Flags: review?(jorgk) → review+
Correct.
Keywords: checkin-needed
(In reply to Jorg K (GMT+2) from comment #8)
> (In reply to Richard Marti (:Paenglab) from comment #7)
> > Removed the no more existing aurora graphic.
> What, where?

In Andreas's patch is still the aurora graphic. We have only the Nightly and Thunderbird branding. Aurora is gone.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4e3c8a149987
Change the background color of the Daily installer graphic to orange. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
You need to log in before you can comment on or make changes to this bug.