Closed Bug 695407 Opened 8 years ago Closed 7 years ago

Modifier keys (e.g. shiftKey) always false for touch events (e.g. touchstart)

Categories

(Firefox for Android :: Keyboards and IME, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 19
Tracking Status
firefox9 --- unaffected
firefox10 --- affected
fennec - ---

People

(Reporter: mbrubeck, Assigned: wesj)

References

Details

(Keywords: testcase)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #694268 +++

We currently hard-code the shiftKey, altKey, metaKey, and ctrlKey properties of touch events to false, but on devices with keyboards they should reflect the actual state of the modifier keys.

Bug 694268 has a test case.
Component: General → Keyboards and IME
Product: Fennec → Firefox for Android
Version: Firefox 10 → Trunk
Assignee: nobody → wjohnston
tracking-fennec: ? → -
Attached patch PatchSplinter Review
I have no device I can test this on, but it should work.
Attachment #668684 - Flags: review?(blassey.bugs)
Attachment #668684 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e898839234e2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Should this have a test?
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.